feat(file): ensure upload of ISO/VSTMPL is completed upon resource creation

[dandaolrian]

The upload of ISO/VMTMPLs uses the Proxmox REST API Upload. But as the code doesn't wait for this to finish you can run into problems deploying the VM

We saw this when creating multiple VMs that were using a "proxmox_virtual_environment_file" to point to our Ubuntu image (~6GB). You could see the upload task was still running on the Proxmox node, but then started creating the VM. This led to a corrupt image that couldn't start

We've added WaitForTask for the upload so that it polls to check it really is uploaded.

Rather that hardcode a timeout (as in network.go) we've added a parameter into "proxmox_virtual_environment_file" which defaults to 1800s but can be overridden

Updated file_test.go that checks the file Schema
Tested locally and with the fix we were then able to create VMs as the upload always completed first

Didn't add anything to examples as this is primarily a fix and the documentation is enough to explain what the new argument does

Contributor's Note

Please mark the following items with an [x] if they apply to your PR.
Leave the [ ] if they are not applicable, or if you have not completed the item.

• I have added / updated documentation in /docs for any user-facing features or additions.
• I have added / updated templates in /examples for any new or updated resources / data sources.
• I have ran make examples to verify that the change works as expected.

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

[bpg]

Thanks a lot @dandaolrian for the PR, this is a really good improvement! 🚀
I've made a few minor changes, namely removed ForceNew flag for the attribute - it change should not cause the resource re-creations.

[bpg]

@all-contributors please add @dandaolrian for code

[allcontributors]

@bpg

I've put up a pull request to add @dandaolrian! 🎉

[bpg]

ah... file resource has no update method, so apparently all non-calculated attributes must have ForceNew set 🤦🏼‍♂️, will revert it back.