fix(lxc): panic on empty initialization.ip_config block

[bpg]

Contributor's Note

• I have added / updated documentation in /docs for any user-facing features or additions.
• I have added / updated templates in /example for any new or updated resources / data sources.
• I have ran make example to verify that the change works as expected.

Proof of Work

Apply & reapply a template with

  initialization {
    ip_config {}
  }

Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # proxmox_virtual_environment_container.test_container will be updated in-place
  ~ resource "proxmox_virtual_environment_container" "test_container" {
        id            = "102"
        tags          = []
        # (7 unchanged attributes hidden)

      ~ initialization {
            # (1 unchanged attribute hidden)

          + ip_config {
            }

            # (1 unchanged block hidden)
        }

        # (5 unchanged blocks hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.
proxmox_virtual_environment_container.test_container: Modifying... [id=102]
proxmox_virtual_environment_container.test_container: Modifications complete after 0s [id=102]

Apply complete! Resources: 0 added, 1 changed, 0 destroyed.

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #936

[mergify]

🤖 LGTM! beep boop

[arcnmx]

While the panic was fixed, it seems that the empty block still causes issues in that the state after refresh/plan/etc never settles even though it will apply now:

# proxmox_virtual_environment_container.lxc_container will be updated in-place
resource "proxmox_virtual_environment_container" "lxc_container" {
  id            = "100"
  # (7 unchanged attributes hidden)
~ initialization {
    # (1 unchanged attribute hidden)
  + ip_config {
    }
    # (2 unchanged blocks hidden)
  }
  # (9 unchanged blocks hidden)
}

[bpg]

Hi @arcnmx,

I've already commented on the other issue, the empty block will always be detected as a pending change. This happens because even though the block is defined in a template and exists in the local state after you run apply, there is nothing related to it one the remote, so the remote state reads as empty.