Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LogScale and LinearScale should inherit from NumericalScale #12

Open
martinRenou opened this issue May 15, 2020 · 0 comments
Open

LogScale and LinearScale should inherit from NumericalScale #12

martinRenou opened this issue May 15, 2020 · 0 comments

Comments

@martinRenou
Copy link
Member

I noticed that LogScale inherits from Scale Python side. But LogScaleModel and LogScale inherits respectively from LinearScaleModel and LinearScale JavaScript side. This means that the LogScale expects some attributes in the widget model that are not set Python side.

I suppose LogScale should at least inherit from LinearScale Python side, and an even cleaner solution could be to have a NumericalScale intermediate class.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@martinRenou