Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/errtrace: Built-in list of exclusions #60

Open
abhinav opened this issue Nov 29, 2023 · 1 comment
Open

cmd/errtrace: Built-in list of exclusions #60

abhinav opened this issue Nov 29, 2023 · 1 comment

Comments

@abhinav
Copy link
Contributor

abhinav commented Nov 29, 2023

From:

          maybe a feature request for future, should we have a set of default opt-outs inbuilt, like don't wrap `io.EOF` when being returned from `Read`? (It's not perfect, but seems like it's never correct to wrap an EOF error from `Read`)

Originally posted by @prashantv in #57 (comment)


We should consider a built-in list of ignores.
These will be pretty simplistic since we don't use type information (yet).
We already have an exclusion for Unwrap() error methods.

This issue is to track both, the feature and what should be in the exclusions initially:

  • io.EOF returned from a Read() (int, error) method
@abhinav abhinav changed the title Built-in list of exclusions cmd/errtrace: Built-in list of exclusions Nov 29, 2023
@Nico-Hab
Copy link

Nico-Hab commented Jun 4, 2024

I just ran into this and wondered why IO code stopped functioning with my Readers, after running the CLI instrumentation tool. This would be very helpful, even if it's not perfect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants