[CLOSED] Linux Sprint 29

[core-ai-bot]

Issue by jasonsanjose
Tuesday Aug 13, 2013 at 17:07 GMT
Originally opened as adobe#297

---

Replaces #288 @JeffryBooher

Replaces scripts/setup_linux_build.sh.

RUN npm install on this branch to update the new dependency on semver.

@timburgess @DaBungalow would you like to test out these updates? Someone else with committer rights will need to handle merging though.

These changes bring the Linux setup and build Grunt tasks up to par with mac and windows. This doesn't replace the one-line wget (see https://gist.github.com/jasonsanjose/5514813) required for downloading the git repositories and installing Node.js and Grunt.

Here are the highlights:

• CEF binaries are now hosted at http://dev.brackets.io. These binaries are modified from the original zip files. To reduce the download size, I've removed the Debug folder. For folks like @timburgess that are doing work with the native shell, it won't be too hard for them to get the full binaries manually.
• There's some extra commits from another outstanding pull [CLOSED] sprint 40 #286. The prior pull should be merged first.
• CEF and Node.js downloads are supported for 32 and 64 bit. I haven't tested the build process on 64-bit yet.
• Speaking of build, you should be able to just pull this branch and run grunt to setup and build. grunt installer will produce the debian package
• There's a new postinstall hook after npm install to install the compile-time dependencies
• Incremental linux builds can be done via grunt build or simply make as before
• Use a template DEBIAN\control file and populate dynamically with brackets version, arch and installed size. See Lintian error: Split linux debian installer CONTROL file for 32 and 64 bit adobe/brackets#4724.

---

jasonsanjose included the following code: https://github.com/adobe/brackets-shell/pull/297/commits

[core-ai-bot]

Comment by JeffryBooher
Friday Aug 16, 2013 at 00:56 GMT

---

I got an error running grunt on Windows "ERROR: Cannot find module 'semver'" but grunt continues and finishes the build. Haven't tried Mac yet.

[core-ai-bot]

Comment by JeffryBooher
Friday Aug 16, 2013 at 06:58 GMT

---

Same error on Mac

[core-ai-bot]

Comment by jasonsanjose
Friday Aug 16, 2013 at 17:42 GMT

---

Updated the pull request description to run npm install to get semver. This will fix the build error on windows.

[core-ai-bot]

Comment by JeffryBooher
Friday Aug 16, 2013 at 18:12 GMT

---

Windows now builds without error

[core-ai-bot]

Comment by timburgess
Monday Aug 19, 2013 at 08:10 GMT

---

No problem with the npm install but I'm failing on the cef-download task with a connect ETIMEDOUT Looks like dev.brackets.io on github is not available(?). My ICMP roundtrips are good everywhere else. Will try again tomorrow AM.

[core-ai-bot]

Comment by jasonsanjose
Monday Aug 19, 2013 at 20:44 GMT

---

@timburgess downloads are fixed now. @adrocknaphobia thinks it could have been a bot.

Anyway, @JeffryBooher pointed out 2 issues over email that I've filed. We can fix these separately from this pull request:

• Failed to load URL data:text/html,chromewebdata with error (-3) in linux dev env adobe/brackets#4828 Symlink libudev for developer environment setup
• Failed to load URL data:text/html,chromewebdata with error (-3) in linux dev env adobe/brackets#4828 Failed to load URL data:text/html,chromewebdata with error (-3) in linux dev env

[core-ai-bot]

Comment by timburgess
Monday Aug 19, 2013 at 21:23 GMT

---

Yup, I can see dev.brackets.io now. The same as master, the CEF version for cef-linux64 has bumped to 3.1547.1354 yet there is no cef_binary_3.1547.1354 on dev.brackets.io/cef so the cef task fails on 64-bit Linux.

I see also that cef-linux32 has CEF 3.1547.1357 hardwired & that is not present on dev.brackets.io/cef either.
Should they both be 3.1547.1357?

I've been working on Linux with prior CEF builds I did myself. Will see if I can get a CEF 3.1547.1357 build via chromium & if so, then can at least test the latter stages too.

[core-ai-bot]

Comment by timburgess
Monday Aug 19, 2013 at 21:25 GMT

---

Ah, missed the comment - ignore the CEF 32bit vs 64bit version question.

[core-ai-bot]

Comment by jasonsanjose
Monday Aug 19, 2013 at 21:38 GMT

---

@timburgess yep we had to hardcode the 32-bit binary since build 1354 wasn't built. This is just temporary until we make our next CEF upgrade.

The zips were just pushed to dev.brackets.io/cef. You can try that out now.

[core-ai-bot]

Comment by timburgess
Monday Aug 19, 2013 at 22:21 GMT

---

Lovely! Works for me but I had a couple of hitches:

• I had a couple of older cef zips in downloads. This was causing cef-download to skip however cef-extract failed on extract because the required version wasn't there
• zip file produces a __MACOSX in deps/ and there is a .DS_Store in deps/cef - the binary build still works however and seems perfectly fine with brackets/master at present

and to clarify, this is on Ubuntu 12.04 64bit

[core-ai-bot]

Comment by JeffryBooher
Monday Aug 19, 2013 at 23:08 GMT

---

Looks like everything is good to go -- just waiting to hear back from legal on the 3rd party code.

[core-ai-bot]

Comment by JeffryBooher
Tuesday Aug 20, 2013 at 00:46 GMT

---

Got clearance from legal...Merging