Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Initial pass of V8 extensions for the new shell #2

Open
core-ai-bot opened this issue Aug 17, 2021 · 1 comment
Open

[CLOSED] Initial pass of V8 extensions for the new shell #2

core-ai-bot opened this issue Aug 17, 2021 · 1 comment

Comments

@core-ai-bot
Copy link
Member

Issue by gruehle
Monday Jun 11, 2012 at 21:20 GMT
Originally opened as adobe#1


Add brackets_extensions.js. This is loaded from client_app.cpp, and has stubbed out versions of all brackets.fs.* and brackets.app.* functions.

The entry point for the V8 extensions is in client_app.cpp, in the AppShellExtensionHandler class. All messages except getElapsedMilliseconds() are forwarded to the browser process (the AppShellExtensionHandler code is run in the renderer process).

Add appshell_extensions.cpp/.h, appshell_extensions_mac.mm, and appshell_extensions_win.cpp. These implement the bulk of the extension functionality and are run in the browser process.

The mac functionality for the implemented methods is complete. There is still work to do on Windows - look for the TODOs in the code.

Other changes:

  • Fix includes so we don't grab them from the cefclient directory
  • Add file_access_from_file_url and universal_access_from_file_url settings
  • Remove more test code

gruehle included the following code: https://github.com/adobe/brackets-shell/pull/1/commits

@core-ai-bot
Copy link
Member Author

Comment by RaymondLim
Monday Jun 11, 2012 at 22:05 GMT


Reviewing...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant