[CLOSED] Hi dpi support in windows.

[core-ai-bot]

Issue by abose
Tuesday Feb 10, 2015 at 13:05 GMT
Originally opened as adobe#502

---

1. Adding HiDPI assets[Minimize, maximize, close, restore button] for windows at 1.25, 1.5,2 and 2.5x scale factors.
2. Changing Application manifest to enable HiDPI support.
3. Loading title bar icons based on current system scale factor.

---

abose included the following code: https://github.com/adobe/brackets-shell/pull/502/commits

[core-ai-bot]

Comment by nethip
Tuesday Feb 10, 2015 at 13:06 GMT

---

@JeffryBooher @redmunds Could you please take a look at this PR.

[core-ai-bot]

Comment by nethip
Tuesday Feb 10, 2015 at 13:15 GMT

---

Also please change the indentation from tabs to spaces.

[core-ai-bot]

Comment by JeffryBooher
Tuesday Feb 10, 2015 at 18:21 GMT

---

Instead of having a different resource for each scale factor, couldn't we just get a really big scale of the image (say 200%) and scale it down with GDI+ to the size we need? I guess we would need to see how good the scaling algorithm is but if the OS adds the ability to scale to more sizes then this will become difficult to manage. It's actually already a little difficult to manage on the resource side as @redmunds points out.

[core-ai-bot]

Comment by abose
Wednesday Feb 11, 2015 at 08:07 GMT

---

I tried scaling 2.5x images , but the downscaled images looked very bad in when scaled then down to 1.2x(the close button reduced to around 5 dots!). Also scaled up images looked pixelated. We just have 4 icons in the title bar to HiDpi-fi and i presume all the rest are svg in cef. With these being the only icons, i think we can keep these icons in these scale factors in the microsoft way untill they come up with some vector solution.