Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Remove a number of unnecessary file associations #362

Open
core-ai-bot opened this issue Aug 17, 2021 · 2 comments
Open

[CLOSED] Remove a number of unnecessary file associations #362

core-ai-bot opened this issue Aug 17, 2021 · 2 comments

Comments

@core-ai-bot
Copy link
Member

Issue by le717
Monday Feb 01, 2016 at 17:49 GMT
Originally opened as adobe#547


Brackets is a front-end web code editor. The Windows installer, however, registers a ton of file associations that were too generic, should belong to another IDE, or were not at all related. Combined with lack of an installation option to choose what should be registered, issues such as adobe/brackets#6073 have been created.

One fix mentioned (and agreed with multiple times) is to drop the aforementioned associations from being registered. This PR does exactly that, dropping, Python, C/C#/C++, Ruby, Java (and like-Java), Perl, and generic extensions (e.g., properties, ini, txt). I left PHP in-place.

With this change, the number of associations registered drops from 92 to 57. That is still a very high number and could still be lowered, but it is already a drastic improvement.


le717 included the following code: https://github.com/adobe/brackets-shell/pull/547/commits

@core-ai-bot
Copy link
Member Author

Comment by ryanstewart
Monday Feb 01, 2016 at 17:57 GMT


Thanks @le717. I don't see any reason not to merge this from an ideal user-experience aspect. @nethip who has the most shell experience on the team to determine if this PR will cause any issues?

@core-ai-bot
Copy link
Member Author

Comment by nethip
Thursday Apr 07, 2016 at 05:24 GMT


Sorry for being really late on this thread.
@ryanstewart Shouldn't be an issue. We could go with the merge.

@le717 Thanks for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant