Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] fixes #11552 #10040

Open
core-ai-bot opened this issue Aug 30, 2021 · 5 comments
Open

[CLOSED] fixes #11552 #10040

core-ai-bot opened this issue Aug 30, 2021 · 5 comments

Comments

@core-ai-bot
Copy link
Member

Issue by zaggino
Thursday Aug 06, 2015 at 20:29 GMT
Originally opened as adobe/brackets#11553


for #11552


zaggino included the following code: https://github.com/adobe/brackets/pull/11553/commits

@core-ai-bot
Copy link
Member Author

Comment by nethip
Friday Aug 07, 2015 at 05:01 GMT


@zaggino: just a quick comment. I see that the documentation for the apis is missing for the new parameter. Could you add description for the newly added parameter at all the places where it is added?

@core-ai-bot
Copy link
Member Author

Comment by zaggino
Friday Aug 07, 2015 at 05:44 GMT


params noted where they were missing

@core-ai-bot
Copy link
Member Author

Comment by abose
Friday Sep 11, 2015 at 11:16 GMT


@zaggino Can we check this change in and add the unit tests as another PR or should this pr be updated?

@core-ai-bot
Copy link
Member Author

Comment by zaggino
Friday Sep 11, 2015 at 11:45 GMT


sure, this is good to check-in... and sorry, but i don't have time to put together a proper test right now

@core-ai-bot
Copy link
Member Author

Comment by abose
Friday Sep 11, 2015 at 12:02 GMT


thanks 👍
Merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant