[CLOSED] Linted CSS

[core-ai-bot]

Issue by AllThingsSmitty
Saturday Feb 27, 2016 at 20:04 GMT
Originally opened as adobe/brackets#12250

---

I went through the sample CSS for the “Getting Started” pages,
reordered rulesets properties to an alpha order, removed properties not
needed (based on last 2 versions of major browsers and IE8+) and
removed unnecessary property values (e.g., em units on line-height).

---

AllThingsSmitty included the following code: https://github.com/adobe/brackets/pull/12250/commits

[core-ai-bot]

Comment by abose
Sunday Feb 28, 2016 at 17:06 GMT

---

@AllThingsSmitty It looks like the license agreement has not been signed. You will need to Accept the Brackets CLA before we can merge this pull request.

[core-ai-bot]

Comment by AllThingsSmitty
Sunday Feb 28, 2016 at 17:09 GMT

---

Done.

I did this yesterday, too, so not sure why it doesn't show.

[core-ai-bot]

Comment by AllThingsSmitty
Friday Mar 18, 2016 at 13:18 GMT

---

@abose any concerns with this PR? Thanks.

[core-ai-bot]

Comment by abose
Monday Mar 21, 2016 at 10:15 GMT

---

@AllThingsSmitty Didn't get enough time to review this yet.
Tagging@swmitra our resident CSS Dinosaur ❗

[core-ai-bot]

Comment by AllThingsSmitty
Wednesday Mar 30, 2016 at 03:53 GMT

---

@abose@swmitra let me know if you have any questions about this PR. Thanks!

[core-ai-bot]

Comment by petetnt
Wednesday Mar 30, 2016 at 06:47 GMT

---

LGTM with one question about zh-tw font-weight

[core-ai-bot]

Comment by AllThingsSmitty
Wednesday Mar 30, 2016 at 10:21 GMT

---

@petetnt good point, I hadn't thought of that. I've reverted it back to the prior font-weight for zh-tw.

[core-ai-bot]

Comment by abose
Thursday Mar 31, 2016 at 15:48 GMT

---

@AllThingsSmitty Release 1.7 will be out this week or the next, so retargeted this for release 1.8 due to inadequate testing window for large changes like this.
Will merge this once Release 1.7 is shipped.

[core-ai-bot]

Comment by AllThingsSmitty
Thursday Mar 31, 2016 at 16:59 GMT

---

@abose sounds good. Looking forward to it.

[core-ai-bot]

Comment by abose
Saturday Apr 02, 2016 at 10:30 GMT

---

LGTM.
Merging, 1.7 is 2-3 weeks away. That should give us adequate testing window.
Thanks@AllThingsSmitty For this change.