Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Homepage url validation for extension listing #10612

Open
core-ai-bot opened this issue Aug 30, 2021 · 3 comments
Open

[CLOSED] Homepage url validation for extension listing #10612

core-ai-bot opened this issue Aug 30, 2021 · 3 comments

Comments

@core-ai-bot
Copy link
Member

Issue by swmitra
Thursday Apr 28, 2016 at 06:14 GMT
Originally opened as adobe/brackets#12389


This PR adds some extra validation on homepage entry in extension listing under ExtensionManager view to make sure local binaries are not getting listed as homepage url.

Ping@nethip@abose@peterflynn for review.


swmitra included the following code: https://github.com/adobe/brackets/pull/12389/commits

@core-ai-bot
Copy link
Member Author

Comment by swmitra
Friday May 13, 2016 at 09:27 GMT


@nethip Local resources without explicit mention of protocol should be checked now with the changes. Only http/https resources will get skipped.

@core-ai-bot
Copy link
Member Author

Comment by nethip
Friday May 13, 2016 at 10:19 GMT


@swmitra There seems to be some undesired changes, now part of the PR. Could you check and revert them?

@core-ai-bot
Copy link
Member Author

Comment by nethip
Friday May 13, 2016 at 12:11 GMT


Travis is failing because of the API limitation. I have manually run grunt build and the build seems to be running fine. LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant