[CLOSED] New File and New Folder execute in project root if there's no selection

[core-ai-bot]

Issue by MarcelGerber
Sunday Sep 04, 2016 at 22:34 GMT
Originally opened as adobe/brackets#12752

---

Fixes #9341 and #11472.

@dangoor's comments in #9341 are interesting, but I think he over-thought this.

The solution is actually as simple as providing an additional param to ProjectManager.getSelectedItem(), which is only false for this one call to the function, so it's not an API change.

---

MarcelGerber included the following code: https://github.com/adobe/brackets/pull/12752/commits

[core-ai-bot]

Comment by ficristo
Wednesday Sep 28, 2016 at 18:22 GMT

---

I think the boolean argument in this case isn't nice. When reading ProjectManager.getSelectedItem(false) is not immediately clear what it is used for.
WDYT of creating a specific function instead? And do you think is worth adding a test?
(I didn't review the rest of the PR)

[core-ai-bot]

Comment by MarcelGerber
Tuesday Jun 13, 2017 at 22:32 GMT

---

@ficristo Quite a long time here, but I've finally incorporated your feedback. Let's take another look!

[core-ai-bot]

Comment by ficristo
Thursday Jun 15, 2017 at 18:59 GMT

---

It seems fine to me.
Just a note: personally I would expect that the new file / folder is always created where people right click.
So if they right click at the root of the project (or in the empty area of the sidebar) the new file / folder should be created at the root of the project despite any selection.

[core-ai-bot]

Comment by MarcelGerber
Thursday Jun 15, 2017 at 23:18 GMT

---

Thinking about that, you are right, that's the way it makes the most sense.
I've changed it that way now.