[CLOSED] Add a feature to toggle between panes in the core #10555

[core-ai-bot]

Issue by arthur801031
Wednesday Oct 26, 2016 at 01:46 GMT
Originally opened as adobe/brackets#12853

---

• I'm not sure if I need to add a menu item for this feature inside "Navigate".
• I'm also not sure if I placed the code inside the correct files since I'm new to open source project contributions.

Thank you!

---

arthur801031 included the following code: https://github.com/adobe/brackets/pull/12853/commits

[core-ai-bot]

Comment by swmitra
Wednesday Oct 26, 2016 at 07:48 GMT

---

@arthur801031 Can you please add/update some tests in MainViewManager test file?

[core-ai-bot]

Comment by arthur801031
Thursday Oct 27, 2016 at 02:02 GMT

---

Hi@swmitra@petetnt , I'm having trouble using the Jasmine Spec Runner for unit tests. I go to Debug -> Run Tests and the content inside the Bracket Tests window is blank. I also can't close that window. It seems like it freezes.

I was also having this problem before I started editing any files.

Here is my Brackets version:

Here is the Developer Tools' Console output:

And I'm using a 15 inch Macbook Pro and macOS Sierra Version 10.12.1. Please help. Thank you very much.

Edit:@petetnt I saw your post #11773. It has the exact same behavior as the one your described. I also tried resetting cache & preferences. I just tried deleting all the files in the brackets folder and I cloned brackets.git from my account and followed the steps in "How to Hack on Brackets" to re-install the code. I'm now getting different error messages in the console:

[core-ai-bot]

Comment by petetnt
Thursday Oct 27, 2016 at 07:26 GMT

---

@arthur801031 Did you run git submodule update --init too?

It might be related to the spec runner window running out of memory and choking too and usually just restarting until it works works too. There's an issue tracking that too somewhere IIRC.

If you have the tests at hand I can try running them too.

[core-ai-bot]

Comment by arthur801031
Thursday Oct 27, 2016 at 08:11 GMT

---

@petetnt I tried restarting the program many times, but Jasmine Spec Runner is still blank. I just submitted the files with the unit test for this feature, but I've never written a unit test before, so I don't know if my code would work. Thank you!

[core-ai-bot]

Comment by arthur801031
Thursday Oct 27, 2016 at 09:28 GMT

---

@petetnt@swmitra
I figured out how to get Jasmine Spec Runner to run. Here is what I did:

1. I used npm install chokidar --save to install chokidar since I was missing the code from chokidar.
2. I used npm install acorn to install acorn since I was missing this as well.
3. There were error messages saying that it's looking for 'acorn' in '/Users/i-chun/Documents/brackets/src/extensions/default/JavaScriptCodeHints', so I created a folder named 'node_modules' and put 'acorn' folder inside this directory.
4. There was also an error message saying that it's looking for 'acorn' in '/Users/i-chun/Documents/brackets/test', so I created a folder named 'node_modules' and put 'acorn' folder inside this directory.

Then, all the error messages in Jasmine Spec Runner's DevTools went away, and the Jasmine Spec Runner is now working correctly.

Note: the unit test that I created for this feature does not work. I will try to modify it. Thank you!

[core-ai-bot]

Comment by zaggino
Thursday Oct 27, 2016 at 09:36 GMT

---

That's weird@arthur801031 , the dependencies you mentioned are already in package.json file. Didn't just npm install install them for you?

[core-ai-bot]

Comment by arthur801031
Thursday Oct 27, 2016 at 09:44 GMT

---

@zaggino I think I ran npm install before, but I'm not 100% sure. But, in my previous comment's bullet point 3, it seemed that 'HintUtils.js', 'main.js', 'Session.js' were looking for 'node_modules/acorn' in their currernt folder, since that folder was not there the Jasmine Spec Runner crash.

[core-ai-bot]

Comment by arthur801031
Thursday Oct 27, 2016 at 10:07 GMT

---

@petetnt @swmitra

The feature and the test function for this feature are now working correctly. I'm not sure why the check has failed for this commit. Please help. Thank you!

[core-ai-bot]

Comment by arthur801031
Friday Oct 28, 2016 at 08:24 GMT

---

@petetnt I finished/uploaded the test and rebased against master branch. Please review my code again. Thank you so much! :)

[core-ai-bot]

Comment by petetnt
Friday Oct 28, 2016 at 08:33 GMT

---

This LGTM, all tests passing. Merging this, thanks a lot@arthur801031, hopefully you'll contribute to Brackets in the future too!

[core-ai-bot]

Comment by swmitra
Friday Oct 28, 2016 at 09:04 GMT

---

Great work@arthur801031 and@petetnt in closing this PR 👍

[core-ai-bot]

Comment by schroef
Friday Mar 24, 2017 at 13:59 GMT

---

SOrry for asking but what button is associated with this, tried google for the icon but cant seem to find it. On mac i need to use cmd+fn+ arrow up/down, my guess its page up/down.

EDIT
found them, http://apple.stackexchange.com/questions/55727/where-can-i-find-the-unicode-symbols-for-mac-functional-keys-command-shift-e

[core-ai-bot]

Comment by swmitra
Friday Mar 24, 2017 at 14:53 GMT

---

If I remember correctly it's Ctrl+w.@petent Can you please confirm?

[core-ai-bot]

Comment by petetnt
Friday Mar 24, 2017 at 14:55 GMT

---

It's Alt+W 👍

[core-ai-bot]

Comment by schroef
Friday Mar 24, 2017 at 16:44 GMT

---

PS perhaps you should add a menu item for this. I noticed the new feature but it only tells us its possible now, doesnt say anything about the shortcut. I was actually mixing it up with switching documents, just know i understood that its for switching when 2 panes are active.