-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLOSED] #7276 Live Preview highlight customization #11017
Comments
Comment by Worie Thanks Also it looks like I've closed this PR 3 hours ago, is it automated process or did i just close it by accident? |
Comment by petetnt These closing is not an automated process, I guess you closed it by accident but that's no biggie 👍 I can help you out with debugging the test failures in a while so we can land this 👍 |
Comment by Worie It isn't pushed yet, but I've created Also I'd like to try to implement adobe/brackets#7276 in my free time, as I think it is an awesome case and it could play well with changes made in this PR. Edit: pushed |
Comment by Worie Preview of Live Preview with margins and paddings showing So, I've done it :) If user did not specify his own preferences, it looks as designed in adobe/brackets#7276 . Also changing those values does not break current Live Development session. You can also turn showing the margins/paddings by changing value of the flag I could probably add one condition to check if there's any padding, so there wont be any borders showing when padding value is equal to 0 or something. And the tests... Yeah. |
Comment by Worie Realized that elements that have css But still, i have no idea how to get into fixing those tests - any help would be awesome, even pointing to some specific files or anything. :) |
Comment by ficristo If you open Chrome at http://localhost:9234/, after clicked |
Comment by Worie Due to This is a pretty simple animation which rotates the element by 90degrees, as you can see the size of element is enlarged in preview due to usage I do not know how to bite this one without some heavy math calculations (nor I am any good at math). Perhaps some of you have an idea how to get the current implementation to act like a chrome one easly? |
Comment by petetnt
|
Comment by Worie Perhaps this will be enough: https://gist.github.com/Worie/caae957b805f08cb733f51406d32aabe Also, now every transform function is applied to the highlight div - probably only scale and rotate should be considered. |
Comment by Worie I've started a little refactor of this code. I'll not focus on the transform issue atm, though. |
Comment by Worie
Of course, I can revert this change and apply the |
Comment by petetnt Hey Worie, sorry for the lack of comms, been a bit busy as of late. Is this PR ready for another round of review? |
Comment by Worie Yeah I guess. If we could only somehow invoke the Anyway - the workaround for transform issue is that we simply do not apply transform to our custom highlightning divs. That means that they dont rotate nor scale, but translation works pretty good on them. I guess that we could perhaps split this into two issues - close this one when the code quality is good enough, and then take care of the transform issue. Because, I think that it might take a while to do (and I have no idea atm how, but I guess we'd need to get the data about the transformations from matrix3d and reverse it to something like |
Comment by petetnt I think the scope is just fine right now, I could run another code review and test it out again myself and then merge it in (and create a issue for tracking the transform part). |
Comment by ficristo I think |
Comment by T3chTobi When will the Live Preview Highlight with Margin and Padding be available? Or can I activate it manually now? |
Comment by T3chTobi This feature is so great and important, can I use it right now through some code implementation? http://imgur.com/Gx1r4P3 |
Comment by Worie You can always clone my fork and set it as a source for Brackets, see how to set up dev environment. Can I somehow help you guys with this PR? I mean, we could discuss the code that's already here, or perhaps I can tell you my way of thinking when i was writing this. Be sure to ping me when anything like this will be necessary. |
Comment by Worie
|
Comment by petetnt LGTM! Can you |
Comment by petetnt Also thanks for this great contribution and sorry that it took so long to get merged 👍 |
Comment by Worie Awesome! Sure, I'll create issues that were not covered in this PR. Thanks! |
Issue by Worie
Sunday Nov 27, 2016 at 18:33 GMT
Originally opened as adobe/brackets#12949
Live Preview highlight customization (colors of highlight can be customized via user preferences)
I needed to easly customize the highlight color of Live Preview - and I've achieved it with the changes in the PR. I'm not sure if that's the desired way of doing so, as this is my first PR to Brackets.
It also implements #7276 -> Preview of Live Preview with margins and paddings showing
Worie included the following code: https://github.com/adobe/brackets/pull/12949/commits
The text was updated successfully, but these errors were encountered: