[CLOSED] Move CodeMirror on node_modules

[core-ai-bot]

Issue by ficristo
Friday Dec 02, 2016 at 14:52 GMT
Originally opened as adobe/brackets#12963

---

What I had in mind was something like this.
I think this will NOT work on distribution since the node_modules would be in a different location.
Also I find worrisome I had to change the css link.

Ref #12940

---

ficristo included the following code: https://github.com/adobe/brackets/pull/12963/commits

[core-ai-bot]

Comment by zaggino
Friday Dec 02, 2016 at 23:36 GMT

---

Looks good to me, let's test how the distribution mode works.

[core-ai-bot]

Comment by ficristo
Saturday Dec 03, 2016 at 16:42 GMT

---

Otherwise we could put another package.json in the src folder.
But the two package.json doesn't seem necessary anymore with the newer versions of electron-builder and I think this is a bit of a contributor barrier.
I still don't have any idea how to change the path for distribution in case of single package.json.
At this point I don't have strong opinions: thoughts?

[core-ai-bot]

Comment by swmitra
Tuesday Dec 06, 2016 at 03:11 GMT

---

@ficristo The changes looks good to me. But I have a different question. When I tried to check the changes on my local machine, I had to do a npm install. Is that expected when someone clones the repo for dev setup?

[core-ai-bot]

Comment by zaggino
Tuesday Dec 06, 2016 at 03:21 GMT

---

@swmitra yes, npm install is expected, it has also been added here: https://github.com/adobe/brackets/wiki/How-to-Hack-on-Brackets#setting-up-your-dev-environment

[core-ai-bot]

Comment by ficristo
Tuesday Dec 06, 2016 at 19:25 GMT

---

I tryed to hack something but I wasn't able to make grunt build to pass. (In the specific grunt requirejs)
If nobody has some bright idea I don't think this will work, as is, on distribution.
I'll create a new package.json inside src and see how this will work.
Of course #12940 is still a choice.

[core-ai-bot]

Comment by ficristo
Thursday Dec 08, 2016 at 08:51 GMT

---

Closing in favor of #12972.