You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
On current master and Windows, grunt write-config still adds changes to my git status, even though the diff is only "warning: LF will be replaced by CRLF in src/config.json."
This now fixes it by making the grunt method common.writeJSON use CRLF line endings on Windows only.
I couldn't test this on Linux or Mac, but it should only affect Windows.
Also, the other times common.writeJSON is used are as follows:
In task build-config writing to dist/config.json
In task npm-install writing to dist/npm-shrinkwrap.json and dist/package.json
In task update-release-number writing to package.json
I don't think the difference of CRLF and LF (used before) matters in these cases, but I'm not 100% sure either and don't know how to test.
cc@ficristo@zaggino #12771 would be fully fixed with this.
Saturday Jun 17, 2017 at 21:15 GMT
Originally opened as adobe/brackets#13458
On current master and Windows,
grunt write-configstill adds changes to mygit status, even though the diff is only "warning: LF will be replaced by CRLF in src/config.json."This now fixes it by making the grunt method
common.writeJSONuse CRLF line endings on Windows only.I couldn't test this on Linux or Mac, but it should only affect Windows.
Also, the other times
common.writeJSONis used are as follows:build-configwriting todist/config.jsonnpm-installwriting todist/npm-shrinkwrap.jsonanddist/package.jsonupdate-release-numberwriting topackage.jsonI don't think the difference of CRLF and LF (used before) matters in these cases, but I'm not 100% sure either and don't know how to test.
cc
@ficristo@zaggino#12771 would be fully fixed with this.
MarcelGerber included the following code: https://github.com/adobe/brackets/pull/13458/commits
The text was updated successfully, but these errors were encountered: