Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLOSED] Fix for "GetItNow" action behaviour #11982

Open
core-ai-bot opened this issue Aug 30, 2021 · 0 comments
Open

[CLOSED] Fix for "GetItNow" action behaviour #11982

core-ai-bot opened this issue Aug 30, 2021 · 0 comments

Comments

@core-ai-bot
Copy link
Member

Issue by swmitra
Tuesday Apr 09, 2019 at 07:36 GMT
Originally opened as adobe/brackets#14691

When user clicks on "GetItNow" it should perform one of these actions

  • Either initialises Auto-Update process after all the conditions verified.
  • Or if Auto-Update can't be initialised, then take the user to brackets.io.

However, we shouldn't perform both the actions.

This PR fixes the faulty behaviour and ensures, we don't open brackets.io if we are able to start auto-update successfully.

@shubhsnov@narayani28 Please review.

swmitra included the following code: https://github.com/adobe/brackets/pull/14691/commits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@core-ai-bot