Find in Files clear error message

[core-ai-bot]

Issue by sriram-dev
Tuesday Jan 13, 2015 at 18:09 GMT
Originally opened as adobe/brackets#10368

---

Fix for #9974
Tests run:

1. jshint
2. tests under Debug->run tests
3. Tests to recreate issue and confirming that it is not seen.

---

sriram-dev included the following code: https://github.com/adobe/brackets/pull/10368/commits

[core-ai-bot]

Comment by sriram-dev
Wednesday Apr 01, 2015 at 05:44 GMT

---

Can someone please review this ?

[core-ai-bot]

Comment by prksingh
Thursday Apr 02, 2015 at 10:06 GMT

---

IMO it may not be a good idea to pass private UI elements. It would be better to keep them segregated and communicate through events

[core-ai-bot]

Comment by sriram-dev
Thursday Apr 02, 2015 at 15:46 GMT

---

@prksingh Yes that sounds like a better approach to take. I will make the changes. Thanks for the suggestion and review.

[core-ai-bot]

Comment by sriram-dev
Friday Apr 03, 2015 at 05:10 GMT

---

Travis CI build failed stating cla-check-pull error? Do I have to re-sign CLA agreement ?

[core-ai-bot]

Comment by prksingh
Tuesday Apr 07, 2015 at 12:00 GMT

---

The error appears to be different from a Cla-check-fail. I have restarted this build

[core-ai-bot]

Comment by prksingh
Tuesday Apr 07, 2015 at 12:33 GMT

---

The build failed again. Its not a cla-check fail though as far as I understand. The error message is: ""API rate limit exceeded ..." Are you in a subnet maybe that is pinging the github server for many requests?

[core-ai-bot]

Comment by sriram-dev
Tuesday Apr 07, 2015 at 12:52 GMT

---

Does that depend on my internet connection ? Not sure. I see jshint failure in files that I havent changed.

[core-ai-bot]

Comment by MarcelGerber
Tuesday Apr 07, 2015 at 17:28 GMT

---

No, it does not depend on your internet connection.
You won't see the JSHint failures any longer if you merge in the latest upstream/master.

[core-ai-bot]

Comment by sriram-dev
Wednesday Apr 08, 2015 at 03:08 GMT

---

All is well now!