Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Live development #1394

Open
core-ai-bot opened this issue Aug 29, 2021 · 5 comments
Open

[CLOSED] Live development #1394

core-ai-bot opened this issue Aug 29, 2021 · 5 comments

Comments

@core-ai-bot
Copy link
Member

Issue by jdiehl
Wednesday Aug 22, 2012 at 14:46 GMT
Originally opened as adobe/brackets#1418


This pull request adds all extra features from the live-development branch, but only enables them if the experimental and autoconnect flags are set in LiveDevelopment/main.js. If this is merged into master, we can get rid of the live-development branch.

Additionally, there are some minor bug fixes and extensions to live-development that have no effect on the productive environment.


jdiehl included the following code: https://github.com/adobe/brackets/pull/1418/commits

@core-ai-bot
Copy link
Member Author

Comment by gruehle
Monday Aug 27, 2012 at 23:41 GMT


Thanks for the annotations in the pull request!

I had couple comments, but everything else looks great.

@core-ai-bot
Copy link
Member Author

Comment by jdiehl
Tuesday Aug 28, 2012 at 06:36 GMT


Github ate your comments when I fixed them!

  1. I changed the way all agents are loaded by using a local variable that is set to either agents or _enabledAgentNames and used to iterate over for loading agents (both objects will return the same keys in a for loop).
  2. I changed brackets.ready to AppInit.appReady.

@core-ai-bot
Copy link
Member Author

Comment by gruehle
Tuesday Aug 28, 2012 at 15:12 GMT


Github ate your comments when I fixed them!

Yeah, GitHub has a new "feature" that automatically hides comments if the line of code that was commented on has changed. You can still get to these comments by clicking "View outdated diff"

@core-ai-bot
Copy link
Member Author

Comment by jdiehl
Tuesday Aug 28, 2012 at 15:18 GMT


Whoops, sorry about including the experimental and autoconnect flags. I removed than and hopefully the pull request is all set now. Thanks for looking at the changes to quickly!

@core-ai-bot
Copy link
Member Author

Comment by gruehle
Tuesday Aug 28, 2012 at 15:39 GMT


Looks good! Thanks.

Merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant