You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Comment by RaymondLim Friday Jan 04, 2013 at 04:40 GMT
@dangoor I'm not seeing any issue with@chtennek changes in the regex. Are you sure you're testing with just that one line change in InlineColorEditor.js?
Comment by dangoor Friday Jan 04, 2013 at 13:35 GMT
@RaymondLim you're absolutely correct. I was looking at the regex in isolation and thought I saw matches that should work but wouldn't. I just tested the cases above in proper context and all but one worked fine. The only one that doesn't work is if there are multiple spaces in front of one of the values, which seems like a bit of a degenerate case, albeit one that actually appears on the MDN page for the color data type.
@chtennek sorry for holding this up, and thanks for the fix (with tests and all). I'll merge it now.
Issue by chtennek
Wednesday Dec 26, 2012 at 14:12 GMT
Originally opened as adobe/brackets#2446
Color Picker doesn't open if alpha value in rgba() starts with .
chtennek included the following code: https://github.com/adobe/brackets/pull/2446/commits
The text was updated successfully, but these errors were encountered: