Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Fix for issue #2227 #2332

Open
core-ai-bot opened this issue Aug 29, 2021 · 2 comments
Open

[CLOSED] Fix for issue #2227 #2332

core-ai-bot opened this issue Aug 29, 2021 · 2 comments

Comments

@core-ai-bot
Copy link
Member

Issue by chtennek
Wednesday Dec 26, 2012 at 14:12 GMT
Originally opened as adobe/brackets#2446


Color Picker doesn't open if alpha value in rgba() starts with .


chtennek included the following code: https://github.com/adobe/brackets/pull/2446/commits

@core-ai-bot
Copy link
Member Author

Comment by RaymondLim
Friday Jan 04, 2013 at 04:40 GMT


@dangoor I'm not seeing any issue with@chtennek changes in the regex. Are you sure you're testing with just that one line change in InlineColorEditor.js?

@core-ai-bot
Copy link
Member Author

Comment by dangoor
Friday Jan 04, 2013 at 13:35 GMT


@RaymondLim you're absolutely correct. I was looking at the regex in isolation and thought I saw matches that should work but wouldn't. I just tested the cases above in proper context and all but one worked fine. The only one that doesn't work is if there are multiple spaces in front of one of the values, which seems like a bit of a degenerate case, albeit one that actually appears on the MDN page for the color data type.

@chtennek sorry for holding this up, and thanks for the fix (with tests and all). I'll merge it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant