Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Live Development files are served with a weird favicon #2858

Open
core-ai-bot opened this issue Aug 29, 2021 · 4 comments
Open

[CLOSED] Live Development files are served with a weird favicon #2858

core-ai-bot opened this issue Aug 29, 2021 · 4 comments

Comments

@core-ai-bot
Copy link
Member

Issue by peterflynn
Tuesday Mar 05, 2013 at 00:46 GMT
Originally opened as adobe/brackets#3038


The browser shows a blue "plug" icon for files loaded through our default localhost server. Looks like this is some default icon that the Connect library provides.

Expected:

  • If the user's project includes a favicon alongside the HTML file, we should use that (I just tested and this is not true today -- not what I expected)
  • If the user's project doesn't have a facivon in the expected location, we show either no favicon (browser uses its own default), as before; or a Brackets-related icon
@core-ai-bot
Copy link
Member Author

Comment by TomMalbran
Tuesday Mar 05, 2013 at 05:48 GMT


It seams to be quite easy to make it always default to a Brackets-related favicon or none, but it doesn't seem that easy to use the user's project includes a favicon alongside the HTML file.

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Wednesday Mar 06, 2013 at 18:56 GMT


Reviewed. Low priority to NJ for Sprint 22. If fix isn't trivial we'll punt to a later sprint.

@core-ai-bot
Copy link
Member Author

Comment by njx
Tuesday Mar 12, 2013 at 17:17 GMT


FBNC@peterflynn

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Thursday Mar 21, 2013 at 21:37 GMT


Cool, looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant