[CLOSED] Add support for complex file extensions like ".coffee.md" or ".html.erb"

[core-ai-bot]

Issue by DennisKehrig
Wednesday Mar 13, 2013 at 12:30 GMT
Originally opened as adobe/brackets#3122

---

The entries in the fileNames field of a language definition can now also contain extensions since file names are checked before extensions are checked.

---

DennisKehrig included the following code: https://github.com/adobe/brackets/pull/3122/commits

[core-ai-bot]

Comment by njx
Wednesday Mar 13, 2013 at 17:30 GMT

---

Open for community committers.

[core-ai-bot]

Comment by jbalsas
Thursday Mar 14, 2013 at 22:36 GMT

---

Reviewing...

[core-ai-bot]

Comment by jbalsas
Thursday Mar 14, 2013 at 22:57 GMT

---

There's a conflict while merging... mostly due to ba472a381d112c7733b0d0926d93da07ea2818fd opening the API. Please, merge with master.

[core-ai-bot]

Comment by jbalsas
Thursday Mar 14, 2013 at 23:35 GMT

---

Finish reviewing...

Looks good, and as we saw in #3083, it already solves a possible use case for ruby files.

@DennisKehrig Please, merge with master. While you're at it, could you update the jsdocs descriptions for addFileName and addFileExtension? Both say "Private for now", but that doesn't seem to be the case anymore.

[core-ai-bot]

Comment by DennisKehrig
Tuesday Mar 19, 2013 at 13:13 GMT

---

Finally: all done!

[core-ai-bot]

Comment by DennisKehrig
Tuesday Mar 19, 2013 at 14:13 GMT

---

I take that back, a unit test fails.

[core-ai-bot]

Comment by DennisKehrig
Tuesday Mar 19, 2013 at 15:17 GMT

---

Good to go now.

[core-ai-bot]

Comment by jbalsas
Tuesday Mar 19, 2013 at 22:55 GMT

---

@DennisKehrig Done with re-review. Behaviour looks great! Just a couple of minor comments...

[core-ai-bot]

Comment by jbalsas
Tuesday Mar 19, 2013 at 23:06 GMT

---

Also, it looks that one of the last merges has created a conflict here, so please, merge with master again :S

[core-ai-bot]

Comment by DennisKehrig
Wednesday Mar 27, 2013 at 22:07 GMT

---

Thank you for the review! I'll get to this tomorrow.

[core-ai-bot]

Comment by DennisKehrig
Friday Mar 29, 2013 at 00:33 GMT

---

Superseded by #3285, closing