Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Fix #3228: Codehints selection popup is positioned wrong when the font size is not standard #3037

Open
core-ai-bot opened this issue Aug 29, 2021 · 4 comments

Comments

@core-ai-bot
Copy link
Member

Issue by TomMalbran
Sunday Mar 24, 2013 at 00:48 GMT
Originally opened as adobe/brackets#3232


This is a fix for #3228, making code hint use the text height when positioning the hinting menu.


TomMalbran included the following code: https://github.com/adobe/brackets/pull/3232/commits

@core-ai-bot
Copy link
Member Author

Comment by WebsiteDeveloper
Sunday Mar 24, 2013 at 06:59 GMT


This looks good so far,
i tested it and it works really nice so thanks for fixing the issue.

@core-ai-bot
Copy link
Member Author

Comment by TomMalbran
Sunday Mar 24, 2013 at 07:07 GMT


Your welcome. I did lots of testing to figure out what were the random numbers from before and to make it look good, knowing why it did. It actually even snaps better when the hints go on top of the cursor too.

@core-ai-bot
Copy link
Member Author

Comment by jbalsas
Friday Mar 29, 2013 at 17:10 GMT


Assign to myself. Reviewing...

@core-ai-bot
Copy link
Member Author

Comment by jbalsas
Friday Mar 29, 2013 at 17:45 GMT


Looks great!

Merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant