[CLOSED] Fix #3412: Cryptic error message when addMenuItem() is passed bad args

[core-ai-bot]

Issue by TomMalbran
Thursday Apr 25, 2013 at 00:20 GMT
Originally opened as adobe/brackets#3611

---

Fix for the issue #3412 by graving the resulting error code from the callback and providing a better error message for each code. I added a similar approach to addMenu() since it had a similar problem.

I searched through the Brackets Shell code to find which where the possible error codes for each function to provide a specific error message for each, but let me know if I missed one, since I mainly went through the Mac implementation since in the Win one was harder to find the error codes, and the list isn't complete in the JavaScript file.

---

TomMalbran included the following code: https://github.com/adobe/brackets/pull/3611/commits

[core-ai-bot]

Comment by redmunds
Friday May 03, 2013 at 23:18 GMT

---

Done with initial review.

[core-ai-bot]

Comment by TomMalbran
Friday May 03, 2013 at 23:52 GMT

---

@redmunds Fixed pushed :)

[core-ai-bot]

Comment by redmunds
Saturday May 04, 2013 at 00:21 GMT

---

Done with review. One more minor comment.

[core-ai-bot]

Comment by redmunds
Saturday May 04, 2013 at 00:32 GMT

---

Merging.