[CLOSED] For Review. Starter feature. Locale descriptions in switching language modal.

[core-ai-bot]

Issue by tammo
Tuesday Apr 30, 2013 at 22:43 GMT
Originally opened as adobe/brackets#3677

---

I came here from the starter feature list and adobe/brackets#1461 .
This is my first pull request ever, and its for review.

There is default behaviour to show just the locales (as it is now). It will lookup a i18n for a locale in the strings.js file of the language. I also added german translations for all current locales.

I think that the translation of every locale should be in that strings.js file as a part of the i18n (does not matter how it is displayed), even if the modal UI is refactored in some time.

I did not write on the mailing list before, because it is just a small hack.

---

tammo included the following code: https://github.com/adobe/brackets/pull/3677/commits

[core-ai-bot]

Comment by tammo
Wednesday May 01, 2013 at 20:24 GMT

---

well i screwed up this pull request by pushing my changes to my master... (i fixed it for the fork repo). the commit (2fe98dd6f6ad303159615f9ac96d7b7982fc9ccf) is still there, so you could have a look at it. if its necessary i will open another pull request. sorry for the inconvenience.

[core-ai-bot]

Comment by TomMalbran
Wednesday May 01, 2013 at 21:39 GMT

---

The request looks good. My only comment is that you should add the LOCALE names to the root strings and the LOCALE LABEL to the de one. Since when a languages doesn't have a string, it uses the root ones, and the translations are made based on the root ones. If possible, move the strings to be close to the other strings for the language modal dialog.

If you want this to have a review and then a merge, you will need to create a new request. For just a review, this is not too bad.