[CLOSED] Issue #3679 - File extension now dimmed if created via File > New

[core-ai-bot]

Issue by rajeshsegu
Wednesday May 01, 2013 at 08:56 GMT
Originally opened as adobe/brackets#3690

---

Looks like the createNewItem() method never used "set_text" on successCallback of creating a new file item.

---

rajeshsegu included the following code: https://github.com/adobe/brackets/pull/3690/commits

[core-ai-bot]

Comment by rajeshsegu
Thursday May 02, 2013 at 04:37 GMT

---

How often does pull requests get merged ?

[core-ai-bot]

Comment by jbalsas
Thursday May 02, 2013 at 07:56 GMT

---

Assign to myself

@rajeshsegu Pull requests are usually merged during one or two sprint periods tops. We've fallen a little bit behind since the team's been focusing on important core features for the last sprints, but we should pick it up soon. In fact, I'll review this one today ;)

[core-ai-bot]

Comment by jbalsas
Thursday May 02, 2013 at 07:58 GMT

---

@rajeshsegu Before we can accept this we'll need you to sign our CLA. You only need to do this once here http://dev.brackets.io/brackets-contributor-license-agreement.html

[core-ai-bot]

Comment by rajeshsegu
Thursday May 02, 2013 at 08:00 GMT

---

Done.

[core-ai-bot]

Comment by jbalsas
Thursday May 02, 2013 at 11:02 GMT

---

@rajeshsegu Thanks for taking this one! Changes look good!

It seems that a commit from adobe/brackets#3687 got leaked to this pull request. I guess you created this branch from master after that commit was already there. You should create separate branches before starting to work on separate issues in order to avoid that. Otherwise, you'd need to hold off any work until your previous requests get merged.

If you plan to work further on adobe/brackets#3669, I'd suggest you to try and rebase this branch to remove that commit so that we won't be merging any additional code in here. Otherwise, we may take this one as is and just close #3687, but I'd rather keep things separated.

[core-ai-bot]

Comment by rajeshsegu
Friday May 03, 2013 at 07:06 GMT

---

@jbalsas rebasing and making the changes again should be easy, but if you can accomodate the below option, I would be happy. Next time I will make sure I submit changes using a branch.

"Otherwise, we may take this one as is and just close #3687."

[core-ai-bot]

Comment by jbalsas
Friday May 03, 2013 at 16:58 GMT

---

@rajeshsegu You forgot to add the "I'd rather keep things separated" when quoting me ;)

I'll go ahead and merge this since it's a very small change that we want in anyway, but please, make sure to keep things separated in the future.

Thanks for start contributing! Hope to see more coming ;)