Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Rolling back to acorn and tern production versions #4351

Open
core-ai-bot opened this issue Aug 29, 2021 · 3 comments
Open

[CLOSED] Rolling back to acorn and tern production versions #4351

core-ai-bot opened this issue Aug 29, 2021 · 3 comments

Comments

@core-ai-bot
Copy link
Member

Issue by JeffryBooher
Thursday Aug 08, 2013 at 22:53 GMT
Originally opened as adobe/brackets#4708


apparently this also converts tabs to spaces in the .gitmodules file also (courtesy of the Whitespace Normalizer extension)


JeffryBooher included the following code: https://github.com/adobe/brackets/pull/4708/commits

@core-ai-bot
Copy link
Member Author

Comment by JeffryBooher
Thursday Aug 08, 2013 at 22:59 GMT


I installed the Whitespace Normalizer Brackets Extension because I was having a problem with LF => CRLF warnings and was hoping that would fix it. It didn't but I still left the Normlizer on. I'm not sure what the policy is for non html/css/js/cpp/h files but it seems that the changes to .gitmodules are dubious (except for the change pointing tern to the official repo) and aren't that big.

I will roll it back, however, if someone is annoyed with the change. I just didn't think it was worth adding another commit for that.

@core-ai-bot
Copy link
Member Author

Comment by njx
Thursday Aug 08, 2013 at 23:12 GMT


The whitespace changes are probably okay (the man page for git config suggests that git is supposed to be lenient to various forms of whitespace in config files), but for future reference it's probably better to make these sorts of changes by using git submodule rather than hand-editing the .gitmodules file.

@core-ai-bot
Copy link
Member Author

Comment by jasonsanjose
Tuesday Aug 13, 2013 at 23:20 GMT


Closing to fixup whitespace issues. See #4766.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant