[CLOSED] Invoking "Find in Files" twice closes the modal bar

[core-ai-bot]

Issue by gruehle
Friday Aug 16, 2013 at 23:56 GMT
Originally opened as adobe/brackets#4802

---

Steps to repro

1. Invoke "Find in Files" (with the keyboard shortcut or selecting the menu item)
2. Invoke it again

Results
The modal bar closes.

This broke with the new modal bar animation.

[core-ai-bot]

Comment by gruehle
Friday Aug 16, 2013 at 23:56 GMT

---

To@njx, medium priority.

[core-ai-bot]

Comment by rajeshsegu
Friday Aug 30, 2013 at 23:24 GMT

---

FindInFilesDialog() in FindinFiles.js should be a singleton, only one instance should exist. I don't understand why we keep recreating it instead of just resetting it.

Anyway, here is the fix running in my mind:

var _currentDialog;
    function _isCurrentDialogShowing(){
        return _currentDialog && !_currentDialog.closed;
    }

    function _setCurrentDialog(dialog){
        _currentDialog = dialog;
    }

In _doFindInFiles() method we just should not create another dialog if _isCurrentDialogShowing() is TRUE.

Let me know if you guys like the idea, I will be happy to make the change.

[core-ai-bot]

Comment by njx
Thursday Sep 19, 2013 at 16:38 GMT

---

The behavior of the modal bar being recreated all the time is a holdover from old CodeMirror code that we copied when originally creating the various find dialogs. I think you're right that it should probably just be a singleton whose content gets swapped out, but we would need to figure out how to make that work for all the various things that use it (find in files, find/replace, and quick open)--some of them behave a little differently. Needs more thought.

[core-ai-bot]

Comment by njx
Thursday Sep 19, 2013 at 16:51 GMT

---

Similar issue to #4500. Added a backlog item that should address this and other related bugs: https://trello.com/c/q2B82Zuv. Closing as move to backlog.

[core-ai-bot]

Comment by rajeshsegu
Friday Sep 20, 2013 at 19:17 GMT

---

@njx@gruehle I say, these are entirely different bugs as they are two different dialog instances. This use-case is to do with the "Find in Files" getting recreating multiple times. Personally, I think they are similar but needs different set of fixes.

I can still take it if you guys are ok. Let me know.