[CLOSED] Fix live preview reload for documentSaved events

[core-ai-bot]

Issue by jasonsanjose
Friday Sep 13, 2013 at 17:03 GMT
Originally opened as adobe/brackets#5207

---

Fix for #5185. Instead of relying on doc.url, simply use the Document.file.fullPath and let the server provide the expected URL.

---

jasonsanjose included the following code: https://github.com/adobe/brackets/pull/5207/commits

[core-ai-bot]

Comment by jasonsanjose
Monday Sep 16, 2013 at 20:32 GMT

---

Updated with fix for #5222.@gruehle ready for review.

[core-ai-bot]

Comment by gruehle
Monday Sep 16, 2013 at 20:53 GMT

---

I'm seeing a failure in the Live Development unit tests: "should reapply in-memory css changes after saving changes in html document".

[core-ai-bot]

Comment by gruehle
Monday Sep 16, 2013 at 20:53 GMT

---

Initial review complete.

[core-ai-bot]

Comment by gruehle
Tuesday Sep 17, 2013 at 13:13 GMT

---

@jasonsanjose re-review complete. Still have one failing unit test.

[core-ai-bot]

Comment by jasonsanjose
Tuesday Sep 17, 2013 at 17:44 GMT

---

@gruehle went a different route to fix the async bug in that test. Changed the tests to wait for the Inspector.Page loadEventFired event instead.

[core-ai-bot]

Comment by gruehle
Tuesday Sep 17, 2013 at 21:05 GMT

---

Everything is working well. It's too bad we need to wait 3 seconds for each of the tests that is expecting the page to not reload, but I can't think of an alternative.

Merging.