Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Reactivate HTML Menu unit tests as part of the test suite #4867

Open
core-ai-bot opened this issue Aug 29, 2021 · 6 comments
Open

Comments

@core-ai-bot
Copy link
Member

Issue by lkcampbell
Monday Sep 23, 2013 at 00:49 GMT
Originally opened as adobe/brackets#5290


This PR is from the following posting:
https://groups.google.com/forum/#!topic/brackets-dev/gJVZgXFq50o


lkcampbell included the following code: https://github.com/adobe/brackets/pull/5290/commits

@core-ai-bot
Copy link
Member Author

Comment by redmunds
Tuesday Sep 24, 2013 at 19:03 GMT


Done with review. This looks pretty good. Just some API cleanup.

@core-ai-bot
Copy link
Member Author

Comment by lkcampbell
Wednesday Sep 25, 2013 at 05:02 GMT


@redmunds, API changes made.

@core-ai-bot
Copy link
Member Author

Comment by lkcampbell
Wednesday Sep 25, 2013 at 13:40 GMT


Edited description to remove new API functions since they are no longer part of the PR.

@core-ai-bot
Copy link
Member Author

Comment by redmunds
Wednesday Sep 25, 2013 at 16:34 GMT


Second review complete.

@core-ai-bot
Copy link
Member Author

Comment by lkcampbell
Thursday Sep 26, 2013 at 03:25 GMT


@redmunds, code updated.

@core-ai-bot
Copy link
Member Author

Comment by redmunds
Thursday Sep 26, 2013 at 15:46 GMT


Looks good. Merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant