[CLOSED] Return the result of calling the original jquery focus() function

[core-ai-bot]

Issue by ingorichter
Wednesday Sep 25, 2013 at 23:07 GMT
Originally opened as adobe/brackets#5346

---

This commit
adobe/brackets@8e5ad95
fixed a focus issue with HTML menus. On Linux (where we still use HTML
menues), the new implementation of focus didn't return the result when
calling the original jquery focus implementation.

The result was an error opening modal dialogs like Extension Manager,
About Box, etc.
The dialogs didn't work properly anymore due to this error:
"Uncaught TypeError: Cannot call method 'trigger' of undefined" in bootstrap-
modal.js

This fix returns the result from calling the original focus function.

---

ingorichter included the following code: https://github.com/adobe/brackets/pull/5346/commits

[core-ai-bot]

Comment by peterflynn
Wednesday Sep 25, 2013 at 23:17 GMT

---

@ingorichter While you're in that code, would you mind adding a comment as noted in this thread?

[core-ai-bot]

Comment by ingorichter
Thursday Sep 26, 2013 at 01:02 GMT

---

@peterflynn is this kind of comment okay?

[core-ai-bot]

Comment by RaymondLim
Friday Sep 27, 2013 at 16:48 GMT

---

@ingorichter Since you merge pr #5350 to master, you will need to merge your branch with master to resolve the conflict.

[core-ai-bot]

Comment by peterflynn
Friday Sep 27, 2013 at 17:57 GMT

---

@ingorichter Yeah, #5350 effectively obsoletes your second commit here. I think we can make a new PR that only contains your original commit. Want me to just do that & then merge it?

[core-ai-bot]

Comment by peterflynn
Friday Sep 27, 2013 at 18:04 GMT

---

Closing in favor of #5364

[core-ai-bot]

Comment by ingorichter
Friday Sep 27, 2013 at 18:34 GMT

---

@peterflynn@RaymondLim Thank you!