Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Quick Find Definition doesn't update on paste (when copying between files) #4930

Open
core-ai-bot opened this issue Aug 29, 2021 · 4 comments

Comments

@core-ai-bot
Copy link
Member

Issue by EvHaus
Thursday Sep 26, 2013 at 16:37 GMT
Originally opened as adobe/brackets#5360


Steps to reproduce:

  1. Load two different files in Brackets that both have the same function definition.
  2. Copy the name of the function in File 1.
  3. Go to File 2 in brackets via the Working Files list.
  4. Press Command + T to open the Quick Find Definition input box
  5. Press Command + V to paste into the Quick Find

Note that the Quick Find doesn't update the results. If you press some arrow keys or any other keydown event -- it will eventually fire.

What should happen:

The Quick Find input should detect a paste command and execute the search for that value.

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Thursday Sep 26, 2013 at 22:13 GMT


I think this was a known issue but I don't see any other bug tracking it. The problem is that 'smartautocomplete' only listens for key events, not text field change events in general.

We might be able to hack around it by catching oninput and forcing a fake onkeyup -- similar to what QuickNavigateDialog.setSearchFieldValue() does when setting the initial text value. But it would be tricky to do that without triggering double notifications for normal typing input.

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Thursday Sep 26, 2013 at 22:14 GMT


Oh, I remember -- this used to work because the keyup from the Ctrl+V shortcut was still visible as a DOM event, and it would trigger smartautocomplete's keyup handler. But now with native menus, I think the shortcut is completely eaten at the native level and no DOM key event occurs.

@core-ai-bot
Copy link
Member Author

Comment by njx
Monday Sep 30, 2013 at 18:29 GMT


Low pri to@dangoor

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Tuesday Apr 07, 2015 at 19:53 GMT


This is fixed in the upcoming 1.3 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant