Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Make sure JS Code Hints list exact matches first #5243

Open
core-ai-bot opened this issue Aug 30, 2021 · 4 comments
Open

[CLOSED] Make sure JS Code Hints list exact matches first #5243

core-ai-bot opened this issue Aug 30, 2021 · 4 comments

Comments

@core-ai-bot
Copy link
Member

Issue by lkcampbell
Saturday Oct 26, 2013 at 15:56 GMT
Originally opened as adobe/brackets#5716


This PR fixes issue #3971.


lkcampbell included the following code: https://github.com/adobe/brackets/pull/5716/commits

@core-ai-bot
Copy link
Member Author

Comment by lkcampbell
Sunday Oct 27, 2013 at 18:35 GMT


@dangoor, I'm not 100% sure this solution is the correct approach. Right now I am addressing the problem at the JavaScript Code Hints level. Should it be be approached at the higher level of the String Match code?

For example, here's a QuickOpen scenario. If I create files xxx.txt and XXY.txt, then enter "xx" or "XX" as my search string, I always get "xxx.txt" as my highest match and "XXY.txt" as my second choice. Is this by design? Should all String Match results be case sensitive or should it be a case by case basis?

@core-ai-bot
Copy link
Member Author

Comment by dangoor
Sunday Oct 27, 2013 at 19:56 GMT


Ideally, StringMatch would have a preference for characters that match the case exactly. I think there may be an issue open on that specifically.

@core-ai-bot
Copy link
Member Author

Comment by lkcampbell
Monday Oct 28, 2013 at 00:23 GMT


In that case, disregard this PR. I want to address this in a broader scope. I will either change this or close it and submit another PR.

@core-ai-bot
Copy link
Member Author

Comment by lkcampbell
Tuesday Oct 29, 2013 at 13:19 GMT


@dangoor, I'm closing this PR, going to try out a different approach this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant