[CLOSED] When autoindenting, only insert a tab if the cursor doesn't move due to CodeMirror's indentation #5326
Comments
|
|
|
Also, note that there's one bit of behavior that isn't changed here: if the cursor is right at the beginning of the text in a line, and it's not already at the right indentation, it just inserts a tab instead of pushing to the correct indentation. This is because it's not easy for us to distinguish between that case and the case where it's already at the right indentation (in which case you do just want to tab over)--we would need to know how much CM expects the line to be indented. I think that's fine for now since we've still improved the behavior overall. |
|
Looks good. Merging. Is this also for adobe/brackets#5633 ? |
|
No, that issue is the one I mentioned in my last comment above that isn't addressed by this pull. |
|
|
Friday Nov 01, 2013 at 20:43 GMT
Originally opened as adobe/brackets#5815
For #5068. This should get rid of the most common case where you can accidentally get extra whitespace at the end of a line.
Note that there's one minor issue remaining with this behavior: if a line is already at the right indent level, you click in the whitespace at the beginning, and you hit TAB, the indentation doesn't change and the cursor moves to the beginning of the text (which is correct), but the file gets marked dirty. I have a comment out to Marijn on this. I don't think it's a showstopper.
njx included the following code: https://github.com/adobe/brackets/pull/5815/commits
The text was updated successfully, but these errors were encountered: