[CLOSED] UrlParams parses a URL without parameters incorrectly

[core-ai-bot]

Issue by lkcampbell
Friday Nov 15, 2013 at 15:33 GMT
Originally opened as adobe/brackets#6008

---

OS Version: Mac OSX Mavericks

Brackets Version: Sprint 33

Repro Steps:
Open Brackets source code, then open Dev Tools to Console and paste the following code snippet into the Console:

UrlParams = require("utils/UrlParams").UrlParams;
var params = new UrlParams();
params.parse("http://www.foobar.com");
params

Look at the value of params._store

Observed Result:
params._store is an object with one property: http://www.foobar.com: "undefined"

Expected Result:
There are no parameters in the URL so params._store should be an empty object.

Additional Notes:
UrlParams needs an isEmpty() method to test for this scenario.

[core-ai-bot]

Comment by lkcampbell
Friday Nov 15, 2013 at 15:41 GMT

---

I am fixing this as part of a bigger fix for adobe/brackets#5078. In addition to fixing this bug and adding the isEmpty() method, I will also be adding a remove() method and a set of unit tests for UrlParams.

[core-ai-bot]

Comment by gruehle
Monday Nov 18, 2013 at 19:18 GMT

---

Reviewed. Low priority to@lkcampbell

[core-ai-bot]

Comment by redmunds
Monday Dec 23, 2013 at 16:59 GMT

---

Thanks. Closing.