-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLOSED] [PM] Installer steals file associations with no warning (for a few users) #5546
Comments
Comment by peterflynn
|
Comment by peterflynn Tentatively assigning |
Comment by aniforprez In my case it overwrote the file associations of MD, Lua, JSON, .properties files. They were previously assigned to other text editors. MD, Lua and JSON where assigned to Sublime Text whereas .properties was assigned to Notepad. |
Comment by msssk I haven't investigated exhaustively, but my .js file association was changed as well as .sh. |
Comment by njx We got a report of this on Twitter as well. |
Comment by peterflynn High priority to investigate for Sprint 35. |
Comment by peterflynn Adjusting title (was: "Installer does not prompt to set file associations") |
Comment by peterflynn
We did have some installer changes in Sprint 34, but I'm having a really hard time seeing how the diff (https://github.com/adobe/brackets-shell/compare/sprint-33...sprint-34?w=1#diff-13) could in any way be causing this. We previously registered only for the Open With list, and we still register only for the Open With list... If that didn't cause bugs before I'm failing to see how it could now. |
Comment by peterflynn Is it possible there's some other common app that uses the registry key |
Comment by Krindi I just installed Brackets for the first time yesterday, Sprint 34, and did not have any file extensions changed without warning. This is on Windows 8.1, which just gives a prompt about having new programs that can open this file. May be a Windows 7 specific issue. |
Comment by peterflynn
|
Comment by msssk
|
Comment by bchintx
So, perhaps I'm just misunderstanding what you're seeing. Can you please clarify with some detailed steps to describe the issue? For example, after installing Brackets, I would expect the following to occur on Windows:
At this point, I would expect that you would see a list of programs, including "Brackets", above the last menu item of "Choose default program...". Of course, clicking "Brackets" would then launch Brackets and open the selected file. This is correct behavior. Are you seeing something different? Or, perhaps, is your concern that the above behavior occurs at all -- ie. that the Brackets installer should have prompted you on install that it was going to add itself to the Open With... list? |
Comment by aniforprez No, it took over completely as the default application for some file types. As in, if I double-click it, it opens in Brackets automatically for those file types and shows the Brackets icon for files of those few types. The files had been previously assigned as defaults to other text editing software. This is slightly irritating, especially because it opens file types that have nothing to do with Brackets' intended functionality. For eg. .properties files. |
Comment by Krindi
|
Comment by pthiess
|
Comment by njx This was somehow tagged both "medium priority" and "high priority". We discussed it in bug review and agreed that it was high priority--we shouldn't be stealing file associations. However, we need to distinguish between people seeing the default file association change vs. just seeing it get added to the Open With list. |
Comment by bchintx
As IMHO, this isn't a med or high priority issue. I'd vote that this be a great enhancement request to the installer UI to allow the user to specify whether/which file extensions they'd like Brackets to register (or not register). I can create a user story in Trello, if that'd help. |
Comment by peterflynn
I agree the issue |
Comment by njx Yes, and we had at least one report on Twitter of the same behavior |
Comment by bchintx
|
Comment by bchintx quick update: I'm able to reproduce the reported behavior if I install Brackets to a clean Win8 system -- ie. that since we install ourselves as the first and only Open With... application, then Win8 will go ahead and use us as the default editor for that file type. However, it there's at least one other application that's also in the Open With... list (by ProgID), then Brackets isn't being used as the default. Also, I haven't (yet) been able to reproduce the problem where a Brackets installation actually steals the association from another previously installed application, but I'm still trying to reproduce this on different systems. (I haven't seen it on Win7 yet at all.) For now, going ahead and clearing the milestone and dropping to Med priority. |
Comment by le717 I have this issue, Windows 8.1 Core x64. I'm on Sprint 35, only previous installation was Sprint 34. I know for sure Brackets now has the file association for JSON (as in, the file opens in Brackets when clicked and has the Brackets logo). Previously it had no association. I'll check for any others when I boot my laptop. I am a bit experienced with Windows installers using Inno Setup and I have read multiple NSIS installer scripts in the past (simply learning how they are written. Those things are difficult to write), so I'll take a quick peek at Bracket's and see if I can catch anything that could cause this stealing. |
Comment by peterflynn
The subject of this bug the case where there was already a file association pointing to some other app, but Brackets overwrites the association when installed. We haven't been able to reproduce that, but we've gotten a couple isolated reports (e.g. from |
Comment by le717
One thing I am definitely seeing is number of file associations the installer makes "Open With" strings for. Take for example
|
Comment by MarcelGerber I appreciate |
Comment by MarcelGerber Looks like this is still a problem: |
Comment by njx Reviewed. Removing 1.0 milestone.
It seems like if we want to make progress, we need to either try again to reproduce the problem, or verify that what people are seeing is expected OS behavior. |
Comment by luisillo26 I'm facing the same issue on Windows 7 64 bits. Brackets overrode some of teh association previously set by Notepad++ and Sublime Text |
Comment by roman02 This has happened to me with Sprint 38. Interestingly, this applied to PHP files, but not to front-end files. (This shouldn't happen silently for any file types.) Windows 8. |
Issue by msssk
Thursday Nov 21, 2013 at 18:24 GMT
Originally opened as adobe/brackets#6073
On Windows 7 the Brackets installer over-writes file associations. It should allow you to specify whether or not you want it to do this.
The text was updated successfully, but these errors were encountered: