Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Add support for DART #5558

Open
core-ai-bot opened this issue Aug 30, 2021 · 26 comments
Open

[CLOSED] Add support for DART #5558

core-ai-bot opened this issue Aug 30, 2021 · 26 comments

Comments

@core-ai-bot
Copy link
Member

Issue by ronag
Friday Nov 22, 2013 at 23:06 GMT
Originally opened as adobe/brackets#6087


@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Friday Nov 22, 2013 at 23:13 GMT


@ronag Would syntax highlighting be enough for your needs? Or are you looking for richer support such as type-aware code hints and Jump to Definition?

@core-ai-bot
Copy link
Member Author

Comment by ronag
Saturday Nov 23, 2013 at 22:54 GMT


Highlighting would be enough to make brackets usable with Dart.

Richer support such as code hints, static analysis. debugging etc... would be even better of course. Would be great to be able to replace dart editor.

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Saturday Nov 23, 2013 at 23:42 GMT


Marked 'move to backlog' -- even highlighting would be nontrivial work since I don't think it's similar enough to other languages to quickly reuse e.g. the "clike" CodeMirror highlighter. This would be a great area for the community to step up and contribute, though (also marking 'Extension Idea').

@core-ai-bot
Copy link
Member Author

Comment by ronag
Sunday Nov 24, 2013 at 10:27 GMT


Would the following be useful? https://code.google.com/p/dart/source/browse/experimental/tools/codemirror/?r=3270

@core-ai-bot
Copy link
Member Author

Comment by ronag
Monday Nov 25, 2013 at 08:40 GMT


Also switching to Dartium could be a good idea for better Dart support.

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Monday Nov 25, 2013 at 18:48 GMT


Ah, interesting: there's a CodeMirror mode (in .js) available here: https://code.google.com/p/dart/source/browse/experimental/tools/codemirror/?r=3270#codemirror%2Fjs%2Fmode%2Fdart. Appears to be MIT-licensed, though its path assumptions would require us patching the file into the CM src tree so it's unfortunately not as easy to integrate as it could be. Seems worth experimenting with if anyone has time.

@ronag What do you mean by "switching to Dartium," though?

@core-ai-bot
Copy link
Member Author

Comment by ronag
Tuesday Nov 26, 2013 at 07:33 GMT


"Dartium is a special build of Chromium that includes the Dart VM. Using Dartium means you don't have to compile your code to JavaScript until you're ready to test on other browsers."

@core-ai-bot
Copy link
Member Author

Comment by ronag
Tuesday Nov 26, 2013 at 07:36 GMT


Switching to Dartium might be a bad idea since it expires every month. However, adding support and the possibility to run on Dartium would be very useful.

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Tuesday Nov 26, 2013 at 09:11 GMT


@ronag What I was getting at though is what would we switch to Dartium? Do you mean support launching Dartium instead of Chrome when you hit the Live Preview button? Or switching the Brackets shell itself (which is currently Chromium via CEF) to Dartium? If the latter, I'm not sure what it would buy us since Brackets isn't written in Dart...

If the former though, that seems reasonable. I'd imagine that would fall under the Live Development with custom Chrome install user story.

@core-ai-bot
Copy link
Member Author

Comment by ronag
Tuesday Nov 26, 2013 at 13:36 GMT


@peterflynn: I am a beginner with both Dart and Brackets. However, my guess would be that if you run the brackets shell itself in Dartium that would possibly enable native debugging of Dart inside of Brackets (without an extra compilation and indirection through dart2js and map files)?

@core-ai-bot
Copy link
Member Author

Comment by rcolinray
Tuesday Feb 11, 2014 at 19:07 GMT


@peterflynn I've been playing around with integrating the CodeMirror file you linked to as an extension. It works for the most part, although brackets hangs on certain syntax (specifically constructor and function arguments). I am still unfamiliar with the CodeMirror format, so I will update as I learn more.

@core-ai-bot
Copy link
Member Author

Comment by architectcodes
Wednesday Jun 18, 2014 at 17:34 GMT


A hacky workaround, which works reasonably for now, is to apply javascript highlighting to dart files. You even get qutocompletion to some extent!

I've modified the plugin brackets-pjs-syntax-highlighting for this purpose.

@core-ai-bot
Copy link
Member Author

Comment by dvorapa
Friday Nov 07, 2014 at 18:48 GMT


Could I ask, if there is any progress in this issue? Is the Dart highlighter close to its implementation to the Brackets?

@core-ai-bot
Copy link
Member Author

Comment by hachre
Friday Nov 07, 2014 at 18:51 GMT


@dvorapa There is a Dart syntax highlighter in the extension menu but I haven't tried it yet.

@core-ai-bot
Copy link
Member Author

Comment by dvorapa
Friday Nov 07, 2014 at 18:59 GMT


I'll do. But anyway, shouldn't it be the default function of the editor instead of an extension?

@core-ai-bot
Copy link
Member Author

Comment by dvorapa
Friday Nov 07, 2014 at 19:11 GMT


It looks like it was assumed from another language highlighter, which's syntax is close, but defferent. It highlights just some of keywords used in Dart.

Edit: excuse me if I repeat something. I think, that it was written somewhere before, but I think, that it was just expressed and not discussed more.

@core-ai-bot
Copy link
Member Author

Comment by tryagains
Saturday Jan 03, 2015 at 03:15 GMT


Hi, It seems the Dart extension is removed from github https://github.com/Arubaruba/Dart-Codemirror
Update needed for Dart 1.8.3 syntax

Dart should have better support! autocompletion and Dartium launcher

@core-ai-bot
Copy link
Member Author

Comment by dvorapa
Saturday Jan 03, 2015 at 10:09 GMT


Well, I thought the same about language support, but now I see it is on us. So let's code new extension!

@core-ai-bot
Copy link
Member Author

Comment by MarcelGerber
Saturday Jan 03, 2015 at 12:12 GMT


CM now has a Dart mode, so we can include that in Brackets 1.2

@core-ai-bot
Copy link
Member Author

Comment by dvorapa
Saturday Jan 03, 2015 at 22:35 GMT


Really? That's great!

@core-ai-bot
Copy link
Member Author

Comment by MarcelGerber
Sunday Jan 04, 2015 at 00:21 GMT


Yeah, you can have a look at the CM Dart demo already.
Notice though it's only syntax-highlighting; code hints and so on still have to be done by an extension.

But I don't see anything preventing us from having a Dart mode in Brackets 1.2

@core-ai-bot
Copy link
Member Author

Comment by dvorapa
Sunday Jan 04, 2015 at 10:23 GMT


Highlighting was the main problem, code hints, analyzer (linter) or live preview (in dartium) are not so important at the moment

@core-ai-bot
Copy link
Member Author

Comment by tryagains
Sunday Jan 04, 2015 at 21:36 GMT


Can live preview in dartium be done via extension?

@core-ai-bot
Copy link
Member Author

Comment by redmunds
Sunday Jan 04, 2015 at 22:32 GMT


@tryagains

Can live preview in dartium be done via extension?

Starting in Brackets 1.1, you can turn on the Live Preview MultiBrowser feature. For details see: https://github.com/adobe/brackets/wiki/Live-Preview-Multibrowser

This will start Live Preview in your default browser, and then you can copy/paste url to any other browser. I'm not sure if anyone's tried dartium, so let us know how it goes.

@core-ai-bot
Copy link
Member Author

Comment by dvorapa
Sunday Jan 04, 2015 at 22:52 GMT


I haven't known about the Live Preview MultiBrowser feature. But it works as expected...

@core-ai-bot
Copy link
Member Author

Comment by MarcelGerber
Saturday Jan 17, 2015 at 21:06 GMT


FYI, Dart mode will be in Brackets 1.2 (and this issue can probably be closed now).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant