[CLOSED] CSS code hints improvements

[core-ai-bot]

Issue by YuAo
Friday Dec 13, 2013 at 17:38 GMT
Originally opened as adobe/brackets#6242

---

Select the initial hint on backspace key press

Problem: When you input "col", the code hint plugin will present hints like "color","column-count",etc, with the initial item "color" selected. But, after you press backspace key once, nothing is selected on the hints list.

This patch set the selectInitial = true on implicitChar === null, making the first hint selected on backspace key press.

Clear hints when nothing's left

Problem: When you input "co", then press backspace twice to delete the CSS property, the code hints list remains open with hints like "align-content","align-items",etc.

This patch fixed the problem by returning null for the hints list when this.info.offset === 0.

---

YuAo included the following code: https://github.com/adobe/brackets/pull/6242/commits

[core-ai-bot]

Comment by redmunds
Thursday Dec 19, 2013 at 16:22 GMT

---

@YuAo My pull request adobe/brackets#6270 that was merged last night conflicts with your code. Sorry about that. You'll have to merge with the latest master before I can review your latest changes. Let me know if you have any questions about the code change.

[core-ai-bot]

Comment by YuAo
Friday Dec 20, 2013 at 02:02 GMT

---

@redmunds That's all right. All fixed now.

[core-ai-bot]

Comment by redmunds
Friday Dec 20, 2013 at 17:23 GMT

---

Thanks. Nice fix. Merging.