[CLOSED] Switch language / syntax mode of current document #5829
Comments
|
The algiment issue is caused by the padding around the actual select. The select doesn't have any border, but it still starts where the "LESS" text is. We could fix it by removing the padding around the select and placing it into the select. |
|
|
|
I added this to Nominations on the Kanban board. |
|
bad alignment can be solved by adding left padding and the same amount of negative margin to the select. i have this fix in my local branch as well. |
|
Sounds good -- thanks! |
|
Instead of using a select can we use something similar to the button dropdown used in the File Filters and CSS Quick Edit, once the File filters are merged? |
|
|
|
The design is nicer too and won't have the same problems as the select has now. The checkmarks will look good too. We just need to wait until the Find Filters are merged to be able to use it. |
|
|
|
Cool, yay! |
|
|
|
Looks good! Thanks |
|
|
|
|
|
|
|
|
|
yeah, i was supposed to review this, but got "contaminated". sorry, |
|
No worries |
|
This works fairly well but I think it needs an Another thing that I think is missing is that it isn't remembered between instances of Brackets. Restarting and opening the same file should remember the setting. That seems like maybe something that could go on the backlog but I'll leave it up to you if you think it's easy to implement. Also closing the file (removing it from the working files list) and reopening it even during the same session loses this setting. |
|
I read that |
|
|
|
|
|
There are a couple of questions to think about:
I'm certain that people will want to be able to save these mappings. But, I'm not certain they'd want this feature delayed in order to get that, and I'm also not certain that how we persist this is clear cut. What if there is no project settings file? What if the file that is being changed is not even in a project? |
|
|
|
|
|
|
|
I agree with My only question is whether we should do anything in the UI to indicate that it's a temporary change -- avoiding confusion or frustration when the language override isn't remembered the next time the file is opened. In the meantime I can make the tweak |
|
Btw |
Wednesday Jan 08, 2014 at 09:32 GMT
Originally opened as adobe/brackets#6409
This is an update of
@JakeStoeffler's PR #4276. It's merged up with the latest master and addresses the main code review comments I made there. I also added some simple unit tests.I still have two concerns about merging this immediately, though:
1) The dropdown UI doesn't look great. It uses a native
<select>, which is just hard to style... and the way the statusbar is laid out makes it look misaligned in this case:It would look nicer if we used an HTML popup like code hints, context menus, and the Recent Projects dropdown... but it would definitely add a bunch more work here. So maybe we can skate by with the current
<select>-based UI for now.@larz0, any thoughts?2) This foregrounds all the bugs in #2911 a lot more. I added a checklist of issues there. Are there any that are prominent enough to act as blockers here? (JS code hints seems like it might be the most glaring issue, but unfortunately that's one of the harder ones to fix too).
peterflynn included the following code: https://github.com/adobe/brackets/pull/6409/commits
The text was updated successfully, but these errors were encountered: