[CLOSED] Fix transition for Replace ModalBar with 2 lines

[core-ai-bot]

Issue by redmunds
Tuesday Apr 15, 2014 at 23:56 GMT
Originally opened as adobe/brackets#7524

---

This is for #7396.

For Replace, the modal bar can only ever be 1 or 2 lines, so I went with a simpler approach. I created a second offscreen2 class for closing a 2 line modal bar, and then conditionally apply the correct class.

I don't see any problem with the transition that opens a 2 line modal bar, so This new class is only used for close.

cc@larz0

---

redmunds included the following code: https://github.com/adobe/brackets/pull/7524/commits

[core-ai-bot]

Comment by redmunds
Tuesday Apr 22, 2014 at 23:15 GMT

---

@larz0 Does this look OK?

[core-ai-bot]

Comment by larz0
Tuesday Apr 22, 2014 at 23:38 GMT

---

@redmunds I'll be able to check this out next week.

[core-ai-bot]

Comment by larz0
Thursday May 01, 2014 at 20:34 GMT

---

@redmunds this is awesome. So much better now!

[core-ai-bot]

Comment by larz0
Thursday May 01, 2014 at 20:37 GMT

---

UX review done.

[core-ai-bot]

Comment by redmunds
Friday May 02, 2014 at 17:20 GMT

---

@TomMalbran I assigned you as reviewer on this one.

[core-ai-bot]

Comment by TomMalbran
Friday May 02, 2014 at 20:51 GMT

---

@redmunds Sure. Do you want to try the easier fix using percentage and fixing the top position from JS, or should I open a new PR?

[core-ai-bot]

Comment by redmunds
Saturday May 03, 2014 at 16:03 GMT

---

@TomMalbran I've been busy with other stuff, so you're welcome to submit a PR. Thanks.

[core-ai-bot]

Comment by redmunds
Sunday May 04, 2014 at 23:54 GMT

---

#7743 is a better fix. Closing.