Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLOSED] About dialog isn't showing all committers #6855

Open
core-ai-bot opened this issue Aug 30, 2021 · 12 comments
Open

[CLOSED] About dialog isn't showing all committers #6855

core-ai-bot opened this issue Aug 30, 2021 · 12 comments

Comments

@core-ai-bot
Copy link
Member

Issue by njx
Thursday Apr 24, 2014 at 00:38 GMT
Originally opened as adobe/brackets#7614

  1. Brackets > About Brackets
  2. Scroll down to see the image grid

Result: Only committers are shown. We used to show all contributors - maybe the GitHub API has changed?
@core-ai-bot
Copy link
Member Author

Comment by njx
Thursday Apr 24, 2014 at 00:38 GMT

Discovered while looking at #7466.

@core-ai-bot
Copy link
Member Author

Comment by MarcelGerber
Thursday Apr 24, 2014 at 00:41 GMT

@njx Well, it's not just the commiters, I'm included as well. But only the 30 first (most contributing) are shown. I'm gonna take a look.

@core-ai-bot
Copy link
Member Author

Comment by TomMalbran
Thursday Apr 24, 2014 at 00:49 GMT

It looks like it returns the results for pagination. If we want more per page, this seems to do the trick:
https://api.github.com/repos/adobe/brackets/contributors?per_page=100000

@core-ai-bot
Copy link
Member Author

Comment by njx
Thursday Apr 24, 2014 at 00:50 GMT

Ah, they probably just lowered the default page size.

@core-ai-bot
Copy link
Member Author

Comment by TomMalbran
Thursday Apr 24, 2014 at 00:51 GMT

Or added a default value of 30.

BTW, this is a dupe of adobe/brackets#7615 or the other way around.

@core-ai-bot
Copy link
Member Author

Comment by MarcelGerber
Friday Apr 25, 2014 at 22:51 GMT

Please reopen this issue, as discussed in #7618

@core-ai-bot
Copy link
Member Author

Comment by njx
Friday Apr 25, 2014 at 22:53 GMT

Done. (It looks like this missed going through FBNC because it got auto-closed when the PR was merged.)

@core-ai-bot
Copy link
Member Author

Comment by njx
Monday Apr 28, 2014 at 18:11 GMT

Updated title. Low pri since we're now at least showing 100 committers instead of 20 :) Assigning@TomMalbran since we asked him to review@SAPlayer's PR - Tom, feel free to push back if you don't have time.

@core-ai-bot
Copy link
Member Author

Comment by TomMalbran
Monday Apr 28, 2014 at 18:13 GMT

Sure. I can do the review.

@core-ai-bot
Copy link
Member Author

Comment by njx
Monday Apr 28, 2014 at 18:36 GMT

Thanks!

@core-ai-bot
Copy link
Member Author

Comment by TomMalbran
Saturday May 10, 2014 at 18:50 GMT

@njx FBNC. This should now be totally fixed :) There are so many contributors.

@core-ai-bot
Copy link
Member Author

Comment by njx
Thursday Jul 10, 2014 at 16:13 GMT

Yup, looks like about 218 now :) Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@core-ai-bot