Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Show all contributors in the AboutDialog #6892

Open
core-ai-bot opened this issue Aug 30, 2021 · 9 comments
Open

[CLOSED] Show all contributors in the AboutDialog #6892

core-ai-bot opened this issue Aug 30, 2021 · 9 comments

Comments

@core-ai-bot
Copy link
Member

Issue by MarcelGerber
Sunday Apr 27, 2014 at 16:28 GMT
Originally opened as adobe/brackets#7666


This is the second fix for #7614, which is respecting the pagination of the GitHub API correctly.


MarcelGerber included the following code: https://github.com/adobe/brackets/pull/7666/commits

@core-ai-bot
Copy link
Member Author

Comment by njx
Monday Apr 28, 2014 at 17:31 GMT


@TomMalbran would you mind finishing the review on this one? thx

@core-ai-bot
Copy link
Member Author

Comment by TomMalbran
Sunday May 04, 2014 at 06:45 GMT


@SAPlayer This looks great, just a few more minor things, and we are probably done.

@core-ai-bot
Copy link
Member Author

Comment by MarcelGerber
Sunday May 04, 2014 at 11:38 GMT


@TomMalbran Ready for another (hopefully the last) review.

@core-ai-bot
Copy link
Member Author

Comment by TomMalbran
Sunday May 04, 2014 at 20:46 GMT


@SAPlayer Just one more idea to add to the dialog.

@core-ai-bot
Copy link
Member Author

Comment by MarcelGerber
Tuesday May 06, 2014 at 16:36 GMT


Notice I won't be able to do any changes on this until Thurday.
In case you need this quickly, feel free to do changes on your own.

@core-ai-bot
Copy link
Member Author

Comment by TomMalbran
Tuesday May 06, 2014 at 16:53 GMT


It looks like the team is getting ready to branch the release branch for Release 39, and this issue is not marked for Release 39. So I guess it might be ok to move it to Release 40.

@core-ai-bot
Copy link
Member Author

Comment by MarcelGerber
Friday May 09, 2014 at 22:17 GMT


It's fine with me now.

@core-ai-bot
Copy link
Member Author

Comment by TomMalbran
Friday May 09, 2014 at 22:20 GMT


I think it looks good to me too. I'll give it a final review and test and merge it.

@core-ai-bot
Copy link
Member Author

Comment by TomMalbran
Saturday May 10, 2014 at 18:49 GMT


Code looks and works great. Thanks for fixing this. Merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant