Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Break out query parsing from setting the query in the model... #7310

Open
core-ai-bot opened this issue Aug 30, 2021 · 0 comments
Open

Comments

@core-ai-bot
Copy link
Member

Issue by njx
Thursday Jun 19, 2014 at 01:36 GMT
Originally opened as adobe/brackets#8174


...so FindInFilesUI doesn't need to touch the model before the search starts (for #6966).

@peterflynn This approach makes it so we don't have to deal with multiple models. There really wasn't any reason for FindInFilesUI to touch the model before actually starting the search, because all it needed was to parse the query and get error info. One the search starts, it's ok to clear the model at that point (and the existing code already does that in FindInFiles.doSearchInScope()).


njx included the following code: https://github.com/adobe/brackets/pull/8174/commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant