You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Issue by njx Thursday Jun 19, 2014 at 01:36 GMT Originally opened as adobe/brackets#8174
...so FindInFilesUI doesn't need to touch the model before the search starts (for #6966).
@peterflynn This approach makes it so we don't have to deal with multiple models. There really wasn't any reason for FindInFilesUI to touch the model before actually starting the search, because all it needed was to parse the query and get error info. One the search starts, it's ok to clear the model at that point (and the existing code already does that in FindInFiles.doSearchInScope()).
Issue by njx
Thursday Jun 19, 2014 at 01:36 GMT
Originally opened as adobe/brackets#8174
...so FindInFilesUI doesn't need to touch the model before the search starts (for #6966).
@
peterflynn This approach makes it so we don't have to deal with multiple models. There really wasn't any reason for FindInFilesUI to touch the model before actually starting the search, because all it needed was to parse the query and get error info. One the search starts, it's ok to clear the model at that point (and the existing code already does that inFindInFiles.doSearchInScope()
).njx included the following code: https://github.com/adobe/brackets/pull/8174/commits
The text was updated successfully, but these errors were encountered: