Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Keep query and replace text when switching between Replace and Replace In Files #8560

Open
core-ai-bot opened this issue Aug 30, 2021 · 6 comments

Comments

@core-ai-bot
Copy link
Member

Issue by MarcelGerber
Monday Oct 20, 2014 at 04:08 GMT
Originally opened as adobe/brackets#9601


For #8531


MarcelGerber included the following code: https://github.com/adobe/brackets/pull/9601/commits

@core-ai-bot
Copy link
Member Author

Comment by redmunds
Tuesday Oct 21, 2014 at 03:52 GMT


@MarcelGerber This looks good. Just a couple minor comments.

@core-ai-bot
Copy link
Member Author

Comment by MarcelGerber
Tuesday Oct 21, 2014 at 04:45 GMT


I wonder if we should put these lines into FindUtils to reduce code duplication?

@core-ai-bot
Copy link
Member Author

Comment by MarcelGerber
Tuesday Oct 21, 2014 at 14:58 GMT


@redmunds Could you take another look?

@core-ai-bot
Copy link
Member Author

Comment by redmunds
Tuesday Oct 21, 2014 at 15:49 GMT


@MarcelGerber Nice refactoring! Just 1 more comment.

@core-ai-bot
Copy link
Member Author

Comment by MarcelGerber
Tuesday Oct 21, 2014 at 17:43 GMT


@redmunds Time for the final review

@core-ai-bot
Copy link
Member Author

Comment by redmunds
Tuesday Oct 21, 2014 at 17:48 GMT


Looks good. Merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant