[CLOSED] [CEF 2171] Inline Editor file names only partly underlined

[core-ai-bot]

Issue by MarcelGerber
Wednesday Nov 26, 2014 at 15:13 GMT
Originally opened as adobe/brackets#10027

---

1. Open DocumentManager.js
2. On line 147, place your cursor on getOpenDocumentForPath
3. Open an Inline Editor (Cmd/Ctrl-E)
4. Hover the displayed file name/line (DocumentManager.js : 123)

Result:
The file name/line is only partly underlined

(Does also reproduce without extensions)

[core-ai-bot]

Comment by MarcelGerber
Wednesday Nov 26, 2014 at 15:16 GMT

---

Maybe related: #7271 and fix #7273.

[core-ai-bot]

Comment by RaymondLim
Wednesday Nov 26, 2014 at 16:32 GMT

---

I can only reproduce it on Windows.

[core-ai-bot]

Comment by peterflynn
Wednesday Nov 26, 2014 at 19:05 GMT

---

Notice that the cutoff aligns exactly with the line number gutter -- so it may be a z-order issue with the gutter elements. We had this exact same bug once before, due to CSS changes: #7271.

[core-ai-bot]

Comment by peterflynn
Wednesday Nov 26, 2014 at 19:29 GMT

---

Interestingly, this repros for me only with the JS inline editor -- not the CSS one. Maybe the presence of the New Rule button is changing things?

In the new CEF, the CodeMirror widget (and its attendant gutter element) is getting positioned 1px higher than it is in the old CEF. That difference could be as simple as font metrics being slightly different.

The box model for that label looks a little funny on both browsers: its parent div doesn't fully fit the link <a> within its bounds -- it hangs partly off the bottom of the bounds. This seems to be due to an inherited line-height: 0px applied to all of .inline-text-editor (I'm actually surprised that hasn't caused more problems already!). Removing that, so the header always has enough room to fit the text, is one way to fix this. The line-height was added in #5818, and it seems like (a) there could be a better fix for that, but also (b) in the bug thread we agreed that this 'fix' wasn't even necessary!

[core-ai-bot]

Comment by dangoor
Monday Dec 08, 2014 at 19:48 GMT

---

Not a release blocker. Removing milestone.