[CLOSED] Update for Serbian translation

[core-ai-bot]

Issue by goranvasic
Sunday Jan 11, 2015 at 20:40 GMT
Originally opened as adobe/brackets#10350

---

Serbian translation was missing translated strings for several menu options and tooltips. These are now covered, and also some previous translations for the UI were modified to be more "user friendly".

---

goranvasic included the following code: https://github.com/adobe/brackets/pull/10350/commits

[core-ai-bot]

Comment by goranvasic
Sunday Jan 11, 2015 at 20:46 GMT

---

I can see that Travis build failed, so I submitted the contributor license agreement here http://dev.brackets.io/brackets-contributor-license-agreement.html

[core-ai-bot]

Comment by RaymondLim
Sunday Jan 11, 2015 at 21:39 GMT

---

@goranvasic You have some duplicate keys that are causing some linting errors.

Linting src/nls/sr/strings.js...ERROR
[L131:C41] W075: Duplicate key 'BUTTON_YES'.
    "BUTTON_YES"                        : "Да",
Linting src/nls/sr/strings.js...ERROR
[L132:C41] W075: Duplicate key 'BUTTON_NO'.
    "BUTTON_NO"                         : "Не",
Linting src/nls/sr/strings.js...ERROR
[L348:C44] W075: Duplicate key 'OK'.
    "OK"                                   : "У реду",
Linting src/nls/sr/strings.js...ERROR
[L349:C44] W075: Duplicate key 'DONT_SAVE'.
    "DONT_SAVE"                            : "Немој сачувати",
Linting src/nls/sr/strings.js...ERROR
[L350:C44] W075: Duplicate key 'SAVE'.
    "SAVE"                                 : "Сачувај",
Linting src/nls/sr/strings.js...ERROR
[L351:C44] W075: Duplicate key 'CANCEL'.
    "CANCEL"                               : "Откажи",
Linting src/nls/sr/strings.js...ERROR
[L352:C44] W075: Duplicate key 'DELETE'.
    "DELETE"                               : "Обриши",

[core-ai-bot]

Comment by goranvasic
Monday Jan 12, 2015 at 21:43 GMT

---

@RaymondLim Could you please check the Travis CI build, it seems that it was not able to properly execute npm command. Note that I submitted my commit directly from web browser.

[core-ai-bot]

Comment by RaymondLim
Monday Jan 12, 2015 at 21:58 GMT

---

@goranvasic Not sure what went wrong with npm, but I restarted the build and it should be fine this time.

[core-ai-bot]

Comment by goranvasic
Monday Jan 12, 2015 at 22:01 GMT

---

@RaymondLim Thank you.

[core-ai-bot]

Comment by goranvasic
Thursday Jan 15, 2015 at 07:47 GMT

---

@RaymondLim I see that this pull request is still not merged so please let me know if there is anything else that needs to be done on my side.

[core-ai-bot]

Comment by RaymondLim
Thursday Jan 15, 2015 at 08:18 GMT

---

@goranvasic Do you have someone that can do the linguistic review?

[core-ai-bot]

Comment by goranvasic
Thursday Jan 15, 2015 at 17:41 GMT

---

@frennky can you please review this translation?

[core-ai-bot]

Comment by frennky
Friday Jan 16, 2015 at 15:37 GMT

---

Everything looks good to me.

[core-ai-bot]

Comment by goranvasic
Friday Jan 16, 2015 at 15:52 GMT

---

@frennky Thanks
@RaymondLim Is this ok to be merged now?