Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLOSED] Make font settings react to pref changes #9783

Open
core-ai-bot opened this issue Aug 30, 2021 · 4 comments
Open

[CLOSED] Make font settings react to pref changes #9783

core-ai-bot opened this issue Aug 30, 2021 · 4 comments

Comments

@core-ai-bot
Copy link
Member

Issue by MarcelGerber
Sunday May 31, 2015 at 22:42 GMT
Originally opened as adobe/brackets#11190

This should go with, or before, #11130.

MarcelGerber included the following code: https://github.com/adobe/brackets/pull/11190/commits
@core-ai-bot
Copy link
Member Author

Comment by MiguelCastillo
Sunday May 31, 2015 at 23:52 GMT

@MarcelGerber changes look good. I am not even sure why I didn't add this with the initial PR, so thanks :)

@core-ai-bot
Copy link
Member Author

Comment by nethip
Monday Jun 01, 2015 at 07:53 GMT

@MarcelGerber thanks for this change! I just have a s comment. Can we change the variable name to something like currFontSizeValue. I guess it would improve the readability of the code. Otherwise LGTM.

@core-ai-bot
Copy link
Member Author

Comment by MarcelGerber
Monday Jun 01, 2015 at 13:44 GMT

Changes pushed.

@core-ai-bot
Copy link
Member Author

Comment by MiguelCastillo
Monday Jun 01, 2015 at 14:26 GMT

looks good, works well. merging in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@core-ai-bot