[CLOSED] Add CodeMirror simple-mode addon

[core-ai-bot]

Issue by sprintr
Monday Jun 15, 2015 at 20:04 GMT
Originally opened as adobe/brackets#11280

---

Allows extension developers to use CodeMirror's simple mode addon. Fixes #11267 and #10501

---

sprintr included the following code: https://github.com/adobe/brackets/pull/11280/commits

[core-ai-bot]

Comment by mackenza
Monday Jun 15, 2015 at 20:22 GMT

---

@sprintr have you tried adding a simple mode as a new language in Brackets with this?

[core-ai-bot]

Comment by sprintr
Monday Jun 15, 2015 at 20:33 GMT

---

@mackenza Yes, I added CodeMirror's handlebars mode as a language to brackets. It worked fine when I tested it against some handlebars strings.

[core-ai-bot]

Comment by MarcelGerber
Friday Jun 19, 2015 at 18:30 GMT

---

This looks good. All unit and integration tests passed.

Merging. Thanks for this awesome contribution!

[core-ai-bot]

Comment by MarcelGerber
Friday Jun 19, 2015 at 18:45 GMT

---

I've also added a note to the wiki page: https://github.com/adobe/brackets/wiki/Language-Support/_compare/2c83f4b3be9bb6cbe86e1ebd5d357d9ca5a2915f...d8aa32d203b7f4f20b9342ac7eb06818c50bde84

[core-ai-bot]

Comment by foice
Friday Aug 07, 2015 at 14:25 GMT

---

Great, your edit of the Language-Support page is already a first step, but to me it still sounds greek.

"To use your custom CodeMirror mode, load it using require(), register it with CodeMirror using CodeMirror.defineMode(), then call LanguageManager.defineLanguage() as above."

maybe it says it all, but only if you know the lingo ... :P

Would it be possible to have a more step by step help page to add a new language from scratch?

At this point such a feature might be a great thing that bracket does, so it is probably worth explaining to the people :)

Thanks a lot
Roberto

[core-ai-bot]

Comment by MarcelGerber
Monday Aug 10, 2015 at 08:27 GMT

---

@foice Tracked as issue #11573.
Please head over there for any further suggestions

[core-ai-bot]

Comment by sprintr
Monday Aug 10, 2015 at 11:02 GMT

---

I have answered about@foice's issue in the brackets-dev group.

@MarcelGerber We can add a couple of examples of using defineMode and defineSimpleMode to the language support wiki page.

[core-ai-bot]

Comment by foice
Monday Aug 10, 2015 at 21:23 GMT

---

Yes I am looking now at Amin Ullah Khan main.js. It looks promising and will give it a try tomorrow.
Thanks to Amin Ullah Khan for sharing and to all of your for the support.

[core-ai-bot]

Comment by foice
Tuesday Aug 11, 2015 at 13:07 GMT

---

The example provided was very helpful. I think I have gone already a good way in coloring my code :)
Will think about extended features and maybe come back if I do not find documentation.
Cheers