Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typos in README Configuration defaults #67

Closed
lkcampbell opened this issue Sep 8, 2017 · 4 comments
Closed

Typos in README Configuration defaults #67

lkcampbell opened this issue Sep 8, 2017 · 4 comments
Assignees

Comments

@lkcampbell
Copy link
Contributor

I didn't notice this until after I updated the README in my last contribution.

The preference names in the README are incorrect.

Any instance of "brackets-eslint.gutterMarks" and "brackets-eslint.useLocalESLint" needs to be changed to "zaggino.brackets-eslint.gutterMarks" and "zaggino.brackets-eslint.useLocalESLint", respectively.

@zaggino zaggino self-assigned this Sep 8, 2017
@zaggino zaggino closed this as completed in 01223b9 Sep 9, 2017
@zaggino
Copy link
Member

zaggino commented Sep 9, 2017

@lkcampbell readme is correct

the extension has zaggino.brackets-eslint id when uploaded to brackets registry because some other extension is blocking brackets-eslint id

the extension has brackets-eslint id when published to npm

@lkcampbell
Copy link
Contributor Author

@zaggino forgive my ignorance, but have we moved to using npm for extension updates?

@zaggino
Copy link
Member

zaggino commented Sep 9, 2017

@lkcampbell nope, but for a long time, brackets-eslint couldn't be in brackets registry because it did not support node_modules

i've created https://github.com/zaggino/brackets-npm-registry to go around that, you can use it to install extensions published to npm

i've also done adobe/brackets#10602 which was merged much later after brackets-npm-registry was created

currently, you can use both ways to install brackets-eslint

@lkcampbell
Copy link
Contributor Author

@zaggino just wondering, because I am have been recently getting a certificate security warning from the Brackets registry site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants