Allow use of custom class names for ordered columns through header at…

[michaelmob]

…tributes

[michaelmob]

I wasn't entirely sure if the TableBase constructor is totally off-limits by adding header_attrs.
Nonetheless, I've added it but it could be changed without too much issue.

I decided that putting header attributes into Column wouldn't make much sense considering someone would have no need for separate ordering attributes for different columns; I believe they would want to change it for the entire table globally.

If opinions differ, give me a better direction to go and I'll attempt to improve on it.

I'll create Docs if it is decided that this implementation is in the right direction for this project. Thanks!

[michaelmob]

Usage would be:

class MyTable(tables.Table):
    [...]
    Meta:
        header_attrs = {
            'orderable': 'sortable',  # Custom ordered class
            'descending': 'descend',  # Custom descending class
            'ascending': 'ascend'  # Custom ascending class
        }

[jieter]

Your point about changing it for a complete table makes sense. I didn't mean to forbid these kind of args to the table constructor, but as said, it's already crowded so we need to consider things carefully.

[michaelmob]

How about this approach.. The most recent commits are what this is.

Instead of having header_attrs in the constructor, a th key is put into the attrs for the table or for the column. Then within that th key, you can put any attribute and value except for _ordering which is reserved for column ordering class names.

For example:

Table(queryset, attrs={
    'th': {
        'class': 'custom-header-class',
        '_ordering': {
            'orderable': 'sort',
            'ascending': 'ascending',
            'descending': 'descending'
        }
    }
})

This will also work for td on table and on a column. If a column provides a separate attrs for td then that will take priority over the table's.

Table(queryset, attrs={
    'td': {
        'class': 'custom-header-class'
    }
})

Hope this made sense. If you're into this approach then I'll write some documentation. (In a more clear manner and more in-depth.)

[jieter]

@thetarkus thanks for trying another approach.

What I like about this is that it's more along the lines for what we have in place for column attributes in Column, what I don't like is the slightly more complex syntax (and mixing ordering settings with direct html attributes). I guess it's a trade-off between number of arguments and complexity of the arguments.

Let's go with this and see how it works out.

[jieter]

@thetarkus looks good, merging